Merge pull request #929 from lightpanda-io/fix-webcomponents

webcomponent must be cast as HTMLElement

Author: karlseguin

src/browser/dom/element.zig

@@ -60,14 +60,24 @@ pub const Element = struct {
 
     pub fn toInterfaceT(comptime T: type, e: *parser.Element) !T {
         const tagname = try parser.elementGetTagName(e) orelse {
-            // in case of null tagname, return the element as it.
+            // If the owner's document is HTML, assume we have an HTMLElement.
+            const doc = try parser.nodeOwnerDocument(parser.elementToNode(e));
+            if (doc != null and !doc.?.is_html) {
+                return .{ .HTMLElement = @as(*parser.ElementHTML, @ptrCast(e)) };
+            }
+
             return .{ .Element = e };
         };
 
         // TODO SVGElement and MathML are not supported yet.
 
         const tag = parser.Tag.fromString(tagname) catch {
-            // if the tag is invalid, we don't have an HTMLElement.
+            // If the owner's document is HTML, assume we have an HTMLElement.
+            const doc = try parser.nodeOwnerDocument(parser.elementToNode(e));
+            if (doc != null and doc.?.is_html) {
+                return .{ .HTMLElement = @as(*parser.ElementHTML, @ptrCast(e)) };
+            }
+
             return .{ .Element = e };
         };
 

src/browser/dom/node.zig

@@ -75,7 +75,14 @@ pub const Node = struct {
             .text => .{ .Text = @as(*parser.Text, @ptrCast(node)) },
             .cdata_section => .{ .CDATASection = @as(*parser.CDATASection, @ptrCast(node)) },
             .processing_instruction => .{ .ProcessingInstruction = @as(*parser.ProcessingInstruction, @ptrCast(node)) },
-            .document => .{ .HTMLDocument = @as(*parser.DocumentHTML, @ptrCast(node)) },
+            .document => blk: {
+                const doc: *parser.Document = @ptrCast(node);
+                if (doc.is_html) {
+                    break :blk .{ .HTMLDocument = @as(*parser.DocumentHTML, @ptrCast(node)) };
+                }
+
+                break :blk .{ .Document = doc };
+            },
             .document_type => .{ .DocumentType = @as(*parser.DocumentType, @ptrCast(node)) },
             .attribute => .{ .Attr = @as(*parser.Attribute, @ptrCast(node)) },
             .document_fragment => .{ .DocumentFragment = @as(*parser.DocumentFragment, @ptrCast(node)) },

src/browser/polyfill/webcomponents.zig

@@ -61,5 +61,7 @@ test "Browser.webcomponents" {
         },
 
         .{ "main.innerHTML", "<lightpanda-test>connected</lightpanda-test>" },
+        .{ "document.createElement('lightpanda-test').dataset", "[object DataSet]" },
+        .{ "document.createElement('lightpanda-test.x').dataset", "[object DataSet]" },
     }, .{});
 }