Skip to content

Commit 9044925

Browse files
committed
emit context created on createTarget event for chromedp
1 parent 2d5ff82 commit 9044925

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

src/browser/browser.zig

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,10 @@ pub const Session = struct {
173173
const page = &self.page.?;
174174
try Page.init(page, page_arena.allocator(), self);
175175

176+
self.notify(&.{ .context_created = .{
177+
.origin = try page.origin(),
178+
} });
179+
176180
// start JS env
177181
log.debug("start new js scope", .{});
178182

src/cdp/cdp.zig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,8 +404,8 @@ pub fn BrowserContext(comptime CDP_T: type) type {
404404
const self: *Self = @alignCast(@ptrCast(ctx));
405405

406406
switch (notification.*) {
407-
.context_created => |cc| {
408-
const aux_data = try std.fmt.allocPrint(self.arena, "{{\"isDefault\":true,\"type\":\"default\",\"frameId\":\"{s}\"}}", .{self.target_id.?});
407+
.context_created => |cc| if (self.target_id) |target_id| {
408+
const aux_data = try std.fmt.allocPrint(self.arena, "{{\"isDefault\":true,\"type\":\"default\",\"frameId\":\"{s}\"}}", .{target_id});
409409
self.inspector.contextCreated(
410410
self.session.page.?.scope,
411411
"",

src/cdp/domains/target.zig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ fn createTarget(cmd: anytype) !void {
123123
const target_id = cmd.cdp.target_id_gen.next();
124124

125125
try bc.createIsolatedWorld();
126+
bc.target_id = target_id;
126127

127128
_ = try bc.session.createPage();
128129

@@ -149,8 +150,6 @@ fn createTarget(cmd: anytype) !void {
149150
try doAttachtoTarget(cmd, target_id);
150151
}
151152

152-
bc.target_id = target_id;
153-
154153
try cmd.sendResult(.{
155154
.targetId = target_id,
156155
}, .{});

0 commit comments

Comments
 (0)