browser: display js err trace on debug mode

krichprollsch · krichprollsch · commit a81d91773bea · 2024-03-08T17:31:03.000+01:00
diff --git a/src/browser/browser.zig b/src/browser/browser.zig
@@ -385,7 +385,11 @@ pub const Page = struct {
             if (res.success) {
                 log.debug("eval inline: {s}", .{res.result});
             } else {
-                log.info("eval inline: {s}", .{res.result});
+                if (builtin.mode == .Debug and res.stack != null) {
+                    log.info("eval inline: {s}", .{res.stack.?});
+                } else {
+                    log.info("eval inline: {s}", .{res.result});
+                }
             }
 
             return;
@@ -438,7 +442,11 @@ pub const Page = struct {
                 };
             }
 
-            log.info("eval remote {s}: {s}", .{ src, res.result });
+            if (builtin.mode == .Debug and res.stack != null) {
+                log.info("eval remote {s}: {s}", .{ src, res.stack.? });
+            } else {
+                log.info("eval remote {s}: {s}", .{ src, res.result });
+            }
             return FetchError.JsErr;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,11 @@ pub const Page = struct {`
`385`	`385`	`if (res.success) {`
`386`	`386`	`log.debug("eval inline: {s}", .{res.result});`
`387`	`387`	`} else {`
`388`		`- log.info("eval inline: {s}", .{res.result});`
	`388`	`+ if (builtin.mode == .Debug and res.stack != null) {`
	`389`	`+ log.info("eval inline: {s}", .{res.stack.?});`
	`390`	`+ } else {`
	`391`	`+ log.info("eval inline: {s}", .{res.result});`
	`392`	`+ }`
`389`	`393`	`}`
`390`	`394`
`391`	`395`	`return;`
`@@ -438,7 +442,11 @@ pub const Page = struct {`
`438`	`442`	`};`
`439`	`443`	`}`
`440`	`444`
`441`		`- log.info("eval remote {s}: {s}", .{ src, res.result });`
	`445`	`+ if (builtin.mode == .Debug and res.stack != null) {`
	`446`	`+ log.info("eval remote {s}: {s}", .{ src, res.stack.? });`
	`447`	`+ } else {`
	`448`	`+ log.info("eval remote {s}: {s}", .{ src, res.result });`
	`449`	`+ }`
`442`	`450`	`return FetchError.JsErr;`
`443`	`451`	`}`
`444`	`452`	`}`