Prototype new test runner

Follows up on #994 and replaces
the jsRunner with a new page.navigation-based test runner.

Currently only implemented for the Window tests, looking for feedback and
converting every existing test will take time - so for a while, newRunner (to be
renamed) will sit side-by-side with jsRunner.

In addition to the benefits outlined in 994, largely around code simplicity and
putting more of the actual code under tests, I think our WebAPI tests
particularly benefit from:
1 - No need to recompile when modifying the html tests
2 - Much better assertions, e.g. you can assert that something is actually an
    array, not just a string representation of an array
3 - Ability to test some edge cases (e.g. dynamic script loading)

I've put some effort into testing.js to make sure that, if the encapsulating
zig test passes, it's because it actually passed, not because it didn't run.

For the time being, console tests are removed. I think it's more useful to have
access to the console within tests, than it is to test the console (which is
just a wrapper around log, which is both tested and heavily used).

Author: karlseguin

src/browser/console/console.zig

@@ -18,13 +18,12 @@
 
 const std = @import("std");
 const builtin = @import("builtin");
+const log = @import("../../log.zig");
 
 const Allocator = std.mem.Allocator;
 const Page = @import("../page.zig").Page;
 const JsObject = @import("../env.zig").Env.JsObject;
 
-const log = if (builtin.is_test) &test_capture else @import("../../log.zig");
-
 pub const Console = struct {
     // TODO: configurable writer
     timers: std.StringHashMapUnmanaged(u32) = .{},
@@ -67,7 +66,7 @@ pub const Console = struct {
             return;
         }
 
-        log.info(.console, "error", .{
+        log.warn(.console, "error", .{
             .args = try serializeValues(values, page),
             .stack = page.stackTrace() catch "???",
         });
@@ -168,161 +167,73 @@ fn timestamp() u32 {
     return @import("../../datetime.zig").timestamp();
 }
 
-var test_capture = TestCapture{};
-const testing = @import("../../testing.zig");
-test "Browser.Console" {
-    defer testing.reset();
-
-    var runner = try testing.jsRunner(testing.tracking_allocator, .{});
-    defer runner.deinit();
-
-    {
-        try runner.testCases(&.{
-            .{ "console.log('a')", "undefined" },
-            .{ "console.warn('hello world', 23, true, new Object())", "undefined" },
-        }, .{});
-
-        const captured = test_capture.captured.items;
-        try testing.expectEqual("[info] args= 1: a", captured[0]);
-        try testing.expectEqual("[warn] args= 1: hello world 2: 23 3: true 4: #<Object>", captured[1]);
-    }
-
-    {
-        test_capture.reset();
-        try runner.testCases(&.{
-            .{ "console.countReset()", "undefined" },
-            .{ "console.count()", "undefined" },
-            .{ "console.count('teg')", "undefined" },
-            .{ "console.count('teg')", "undefined" },
-            .{ "console.count('teg')", "undefined" },
-            .{ "console.count()", "undefined" },
-            .{ "console.countReset('teg')", "undefined" },
-            .{ "console.countReset()", "undefined" },
-            .{ "console.count()", "undefined" },
-        }, .{});
-
-        const captured = test_capture.captured.items;
-        try testing.expectEqual("[invalid counter] label=default", captured[0]);
-        try testing.expectEqual("[count] label=default count=1", captured[1]);
-        try testing.expectEqual("[count] label=teg count=1", captured[2]);
-        try testing.expectEqual("[count] label=teg count=2", captured[3]);
-        try testing.expectEqual("[count] label=teg count=3", captured[4]);
-        try testing.expectEqual("[count] label=default count=2", captured[5]);
-        try testing.expectEqual("[count reset] label=teg count=3", captured[6]);
-        try testing.expectEqual("[count reset] label=default count=2", captured[7]);
-        try testing.expectEqual("[count] label=default count=1", captured[8]);
-    }
-
-    {
-        test_capture.reset();
-        try runner.testCases(&.{
-            .{ "console.assert(true)", "undefined" },
-            .{ "console.assert('a', 2, 3, 4)", "undefined" },
-            .{ "console.assert('')", "undefined" },
-            .{ "console.assert('', 'x', true)", "undefined" },
-            .{ "console.assert(false, 'x')", "undefined" },
-        }, .{});
-
-        const captured = test_capture.captured.items;
-        try testing.expectEqual("[assertion failed] values=", captured[0]);
-        try testing.expectEqual("[assertion failed] values= 1: x 2: true", captured[1]);
-        try testing.expectEqual("[assertion failed] values= 1: x", captured[2]);
-    }
-
-    {
-        test_capture.reset();
-        try runner.testCases(&.{
-            .{ "[1].forEach(console.log)", null },
-        }, .{});
-
-        const captured = test_capture.captured.items;
-        try testing.expectEqual("[info] args= 1: 1 2: 0 3: [1]", captured[0]);
-    }
-}
-
-const TestCapture = struct {
-    captured: std.ArrayListUnmanaged([]const u8) = .{},
-
-    fn separator(_: *const TestCapture) []const u8 {
-        return " ";
-    }
-
-    fn reset(self: *TestCapture) void {
-        self.captured = .{};
-    }
-
-    fn debug(
-        self: *TestCapture,
-        comptime scope: @Type(.enum_literal),
-        comptime msg: []const u8,
-        args: anytype,
-    ) void {
-        self.capture(scope, msg, args);
-    }
-
-    fn info(
-        self: *TestCapture,
-        comptime scope: @Type(.enum_literal),
-        comptime msg: []const u8,
-        args: anytype,
-    ) void {
-        self.capture(scope, msg, args);
-    }
-
-    fn warn(
-        self: *TestCapture,
-        comptime scope: @Type(.enum_literal),
-        comptime msg: []const u8,
-        args: anytype,
-    ) void {
-        self.capture(scope, msg, args);
-    }
-
-    fn err(
-        self: *TestCapture,
-        comptime scope: @Type(.enum_literal),
-        comptime msg: []const u8,
-        args: anytype,
-    ) void {
-        self.capture(scope, msg, args);
-    }
-
-    fn fatal(
-        self: *TestCapture,
-        comptime scope: @Type(.enum_literal),
-        comptime msg: []const u8,
-        args: anytype,
-    ) void {
-        self.capture(scope, msg, args);
-    }
-
-    fn capture(
-        self: *TestCapture,
-        comptime scope: @Type(.enum_literal),
-        comptime msg: []const u8,
-        args: anytype,
-    ) void {
-        self._capture(scope, msg, args) catch unreachable;
-    }
-
-    fn _capture(
-        self: *TestCapture,
-        comptime scope: @Type(.enum_literal),
-        comptime msg: []const u8,
-        args: anytype,
-    ) !void {
-        std.debug.assert(scope == .console);
-
-        const allocator = testing.arena_allocator;
-        var buf: std.ArrayListUnmanaged(u8) = .empty;
-        try buf.appendSlice(allocator, "[" ++ msg ++ "] ");
-
-        inline for (@typeInfo(@TypeOf(args)).@"struct".fields) |f| {
-            try buf.appendSlice(allocator, f.name);
-            try buf.append(allocator, '=');
-            try @import("../../log.zig").writeValue(.pretty, @field(args, f.name), buf.writer(allocator));
-            try buf.append(allocator, ' ');
-        }
-        self.captured.append(testing.arena_allocator, std.mem.trimRight(u8, buf.items, " ")) catch unreachable;
-    }
-};
+// const testing = @import("../../testing.zig");
+// test "Browser.Console" {
+//     defer testing.reset();
+
+//     var runner = try testing.jsRunner(testing.tracking_allocator, .{});
+//     defer runner.deinit();
+
+//     {
+//         try runner.testCases(&.{
+//             .{ "console.log('a')", "undefined" },
+//             .{ "console.warn('hello world', 23, true, new Object())", "undefined" },
+//         }, .{});
+
+//         const captured = test_capture.captured.items;
+//         try testing.expectEqual("[info] args= 1: a", captured[0]);
+//         try testing.expectEqual("[warn] args= 1: hello world 2: 23 3: true 4: #<Object>", captured[1]);
+//     }
+
+//     {
+//         test_capture.reset();
+//         try runner.testCases(&.{
+//             .{ "console.countReset()", "undefined" },
+//             .{ "console.count()", "undefined" },
+//             .{ "console.count('teg')", "undefined" },
+//             .{ "console.count('teg')", "undefined" },
+//             .{ "console.count('teg')", "undefined" },
+//             .{ "console.count()", "undefined" },
+//             .{ "console.countReset('teg')", "undefined" },
+//             .{ "console.countReset()", "undefined" },
+//             .{ "console.count()", "undefined" },
+//         }, .{});
+
+//         const captured = test_capture.captured.items;
+//         try testing.expectEqual("[invalid counter] label=default", captured[0]);
+//         try testing.expectEqual("[count] label=default count=1", captured[1]);
+//         try testing.expectEqual("[count] label=teg count=1", captured[2]);
+//         try testing.expectEqual("[count] label=teg count=2", captured[3]);
+//         try testing.expectEqual("[count] label=teg count=3", captured[4]);
+//         try testing.expectEqual("[count] label=default count=2", captured[5]);
+//         try testing.expectEqual("[count reset] label=teg count=3", captured[6]);
+//         try testing.expectEqual("[count reset] label=default count=2", captured[7]);
+//         try testing.expectEqual("[count] label=default count=1", captured[8]);
+//     }
+
+//     {
+//         test_capture.reset();
+//         try runner.testCases(&.{
+//             .{ "console.assert(true)", "undefined" },
+//             .{ "console.assert('a', 2, 3, 4)", "undefined" },
+//             .{ "console.assert('')", "undefined" },
+//             .{ "console.assert('', 'x', true)", "undefined" },
+//             .{ "console.assert(false, 'x')", "undefined" },
+//         }, .{});
+
+//         const captured = test_capture.captured.items;
+//         try testing.expectEqual("[assertion failed] values=", captured[0]);
+//         try testing.expectEqual("[assertion failed] values= 1: x 2: true", captured[1]);
+//         try testing.expectEqual("[assertion failed] values= 1: x", captured[2]);
+//     }
+
+//     {
+//         test_capture.reset();
+//         try runner.testCases(&.{
+//             .{ "[1].forEach(console.log)", null },
+//         }, .{});
+
+//         const captured = test_capture.captured.items;
+//         try testing.expectEqual("[info] args= 1: 1 2: 0 3: [1]", captured[0]);
+//     }
+// }