Merge pull request #996 from lightpanda-io/revert-document-element

karlseguin · web-flow · commit d4fc6f1b351b · 2025-09-02T06:52:16.000+08:00
Revert "document.documentElement returns a *parser.Element"
diff --git a/src/browser/dom/document.zig b/src/browser/dom/document.zig
@@ -66,8 +66,10 @@ pub const Document = struct {
         return DOMImplementation{};
     }
 
-    pub fn get_documentElement(self: *parser.Document) !?*parser.Element {
-        return try parser.documentGetDocumentElement(self);
+    pub fn get_documentElement(self: *parser.Document) !?ElementUnion {
+        const e = try parser.documentGetDocumentElement(self);
+        if (e == null) return null;
+        return try Element.toInterface(e.?);
     }
 
     pub fn get_documentURI(self: *parser.Document) ![]const u8 {

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,10 @@ pub const Document = struct {`
`66`	`66`	`return DOMImplementation{};`
`67`	`67`	`}`
`68`	`68`
`69`		`- pub fn get_documentElement(self: parser.Document) !?parser.Element {`
`70`		`- return try parser.documentGetDocumentElement(self);`
	`69`	`+ pub fn get_documentElement(self: *parser.Document) !?ElementUnion {`
	`70`	`+ const e = try parser.documentGetDocumentElement(self);`
	`71`	`+ if (e == null) return null;`
	`72`	`+ return try Element.toInterface(e.?);`
`71`	`73`	`}`
`72`	`74`
`73`	`75`	`pub fn get_documentURI(self: *parser.Document) ![]const u8 {`