Skip to content

Commit dffbce1

Browse files
authored
Merge pull request #712 from lightpanda-io/tweak_http_logs
Reduce info logs of HTTP event
2 parents 06a33b0 + 79d1425 commit dffbce1

File tree

2 files changed

+21
-9
lines changed

2 files changed

+21
-9
lines changed

src/browser/page.zig

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ pub const Page = struct {
181181
const session = self.session;
182182
const notification = session.browser.notification;
183183

184-
log.info(.page, "navigate", .{ .url = request_url, .reason = opts.reason });
184+
log.debug(.page, "navigate", .{ .url = request_url, .reason = opts.reason });
185185

186186
// if the url is about:blank, nothing to do.
187187
if (std.mem.eql(u8, "about:blank", request_url.raw)) {
@@ -229,7 +229,12 @@ pub const Page = struct {
229229
break :blk Mime.sniff(try response.peek());
230230
} orelse .unknown;
231231

232-
log.info(.page, "navigation header", .{ .status = header.status, .content_type = content_type, .charset = mime.charset });
232+
log.info(.page, "navigation", .{
233+
.status = header.status,
234+
.content_type = content_type,
235+
.charset = mime.charset,
236+
.url = request_url,
237+
});
233238

234239
if (mime.isHTML()) {
235240
self.raw_data = null;
@@ -248,7 +253,7 @@ pub const Page = struct {
248253
.url = &self.url,
249254
.timestamp = timestamp(),
250255
});
251-
log.info(.page, "navigation complete", .{});
256+
log.debug(.page, "navigation complete", .{});
252257
}
253258

254259
// https://html.spec.whatwg.org/#read-html
@@ -439,8 +444,8 @@ pub const Page = struct {
439444
var origin_url = &self.url;
440445
const url = try origin_url.resolve(arena, res_src);
441446

442-
log.info(.page, "fetching script", .{ .url = url });
443-
errdefer |err| log.err(.page, "fetch error", .{ .err = err });
447+
log.debug(.page, "fetching script", .{ .url = url });
448+
errdefer |err| log.err(.page, "fetch error", .{ .err = err, .url = url });
444449

445450
var request = try self.newHTTPRequest(.GET, &url, .{
446451
.origin_uri = &origin_url.uri,
@@ -468,7 +473,11 @@ pub const Page = struct {
468473
return null;
469474
}
470475

471-
log.info(.page, "fetch complete", .{ .status = header.status, .content_length = arr.items.len });
476+
log.info(.page, "fetch complete", .{
477+
.url = url,
478+
.status = header.status,
479+
.content_length = arr.items.len,
480+
});
472481
return arr.items;
473482
}
474483

src/browser/xhr/xhr.zig

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ pub const XMLHttpRequest = struct {
412412
if (self.state != .opened) return DOMError.InvalidState;
413413
if (self.send_flag) return DOMError.InvalidState;
414414

415-
log.info(.xhr, "request", .{ .method = self.method, .url = self.url });
415+
log.debug(.xhr, "request", .{ .method = self.method, .url = self.url });
416416

417417
self.send_flag = true;
418418

@@ -459,7 +459,7 @@ pub const XMLHttpRequest = struct {
459459
if (progress.first) {
460460
const header = progress.header;
461461

462-
log.info(.xhr, "request header", .{ .status = header.status });
462+
log.debug(.xhr, "request header", .{ .status = header.status });
463463
for (header.headers.items) |hdr| {
464464
try self.response_headers.append(hdr.name, hdr.value);
465465
}
@@ -505,7 +505,10 @@ pub const XMLHttpRequest = struct {
505505
return;
506506
}
507507

508-
log.info(.xhr, "request complete", .{});
508+
log.info(.xhr, "request complete", .{
509+
.url = self.url,
510+
.status = progress.header.status,
511+
});
509512

510513
self.state = .done;
511514
self.send_flag = false;

0 commit comments

Comments
 (0)