Skip to content

Commit e237e70

Browse files
committed
Change loader id on navigation
This appears to be what chrome is doing. I don't know why we weren't before.
1 parent 2ac9b20 commit e237e70

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/cdp/cdp.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ pub fn CDPT(comptime TypeProvider: type) type {
103103
pub fn handleMessage(self: *Self, msg: []const u8) bool {
104104
// if there's an error, it's already been logged
105105
self.processMessage(msg) catch return false;
106-
// self.pageWait();
107106
return true;
108107
}
109108

src/cdp/domains/page.zig

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,7 @@ pub fn pageNavigate(arena: Allocator, bc: anytype, event: *const Notification.Pa
164164

165165
var cdp = bc.cdp;
166166

167-
if (event.opts.reason != .address_bar) {
168-
bc.loader_id = bc.cdp.loader_id_gen.next();
169-
}
170-
167+
bc.loader_id = bc.cdp.loader_id_gen.next();
171168
const loader_id = bc.loader_id;
172169
const target_id = bc.target_id orelse unreachable;
173170
const session_id = bc.session_id orelse unreachable;

0 commit comments

Comments
 (0)