Re-introduce postAttach

index_get seems to be ~1000x slower than setting the value directly on the
v8.Object. There's a lot of information on "v8 fast properties", and values
set directly on objects seem to be heavily optimized. Still, I can't imagine
indexed properties are always _that_ slow, so I must be doing something wrong.
Still, for now, this brings back the original functionality / behavior / perf.

Introduce the ability for Zig functions to take a Env.JsObject parameter. While
this isn't currently being used, it aligns with bringing back the postAttach /
JSObject functionality in main.

Moved function *State to the end of the function list (making it consistent with
getters and setters). The optional Env.JsObject parameter comes after the
optional state.

Removed some uncessary arena deinits from a few webapis.

Author: karlseguin

src/browser/dom/comment.zig

@@ -28,7 +28,7 @@ pub const Comment = struct {
     pub const Self = parser.Comment;
     pub const prototype = *CharacterData;
 
-    pub fn constructor(state: *const SessionState, data: ?[]const u8) !*parser.Comment {
+    pub fn constructor(data: ?[]const u8, state: *const SessionState) !*parser.Comment {
         return parser.documentCreateComment(
             parser.documentHTMLToDocument(state.document.?),
             data orelse "",

src/browser/dom/document.zig

@@ -138,16 +138,16 @@ pub const Document = struct {
     // HTMLCollection in zig here.
     pub fn _getElementsByTagName(
         self: *parser.Document,
-        state: *SessionState,
         tag_name: []const u8,
+        state: *SessionState,
     ) !collection.HTMLCollection {
         return try collection.HTMLCollectionByTagName(state.arena, parser.documentToNode(self), tag_name, true);
     }
 
     pub fn _getElementsByClassName(
         self: *parser.Document,
-        state: *SessionState,
         classNames: []const u8,
+        state: *SessionState,
     ) !collection.HTMLCollection {
         const allocator = state.arena;
         return try collection.HTMLCollectionByClassName(allocator, parser.documentToNode(self), classNames, true);
@@ -212,7 +212,7 @@ pub const Document = struct {
         return 1;
     }
 
-    pub fn _querySelector(self: *parser.Document, state: *SessionState, selector: []const u8) !?ElementUnion {
+    pub fn _querySelector(self: *parser.Document, selector: []const u8, state: *SessionState) !?ElementUnion {
         if (selector.len == 0) return null;
 
         const allocator = state.arena;
@@ -223,7 +223,7 @@ pub const Document = struct {
         return try Element.toInterface(parser.nodeToElement(n.?));
     }
 
-    pub fn _querySelectorAll(self: *parser.Document, state: *SessionState, selector: []const u8) !NodeList {
+    pub fn _querySelectorAll(self: *parser.Document, selector: []const u8, state: *SessionState) !NodeList {
         const allocator = state.arena;
         return css.querySelectorAll(allocator, parser.documentToNode(self), selector);
     }

src/browser/dom/element.zig

@@ -226,8 +226,8 @@ pub const Element = struct {
 
     pub fn _getElementsByTagName(
         self: *parser.Element,
-        state: *SessionState,
         tag_name: []const u8,
+        state: *SessionState,
     ) !collection.HTMLCollection {
         return try collection.HTMLCollectionByTagName(
             state.arena,
@@ -239,8 +239,8 @@ pub const Element = struct {
 
     pub fn _getElementsByClassName(
         self: *parser.Element,
-        state: *SessionState,
         classNames: []const u8,
+        state: *SessionState,
     ) !collection.HTMLCollection {
         return try collection.HTMLCollectionByClassName(
             state.arena,
@@ -306,7 +306,7 @@ pub const Element = struct {
         }
     }
 
-    pub fn _querySelector(self: *parser.Element, state: *SessionState, selector: []const u8) !?Union {
+    pub fn _querySelector(self: *parser.Element, selector: []const u8, state: *SessionState) !?Union {
         if (selector.len == 0) return null;
 
         const n = try css.querySelector(state.arena, parser.elementToNode(self), selector);
@@ -316,7 +316,7 @@ pub const Element = struct {
         return try toInterface(parser.nodeToElement(n.?));
     }
 
-    pub fn _querySelectorAll(self: *parser.Element, state: *SessionState, selector: []const u8) !NodeList {
+    pub fn _querySelectorAll(self: *parser.Element, selector: []const u8, state: *SessionState) !NodeList {
         return css.querySelectorAll(state.arena, parser.elementToNode(self), selector);
     }
 

src/browser/dom/event_target.zig

@@ -46,10 +46,10 @@ pub const EventTarget = struct {
 
     pub fn _addEventListener(
         self: *parser.EventTarget,
-        state: *SessionState,
         eventType: []const u8,
         cbk: Env.Callback,
         capture: ?bool,
+        state: *SessionState,
         // TODO: hanle EventListenerOptions
         // see #https://github.com/lightpanda-io/jsruntime-lib/issues/114
     ) !void {
@@ -76,10 +76,10 @@ pub const EventTarget = struct {
 
     pub fn _removeEventListener(
         self: *parser.EventTarget,
-        state: *SessionState,
         eventType: []const u8,
         cbk: Env.Callback,
         capture: ?bool,
+        state: *SessionState,
         // TODO: hanle EventListenerOptions
         // see #https://github.com/lightpanda-io/jsruntime-lib/issues/114
     ) !void {

src/browser/dom/html_collection.zig

@@ -24,6 +24,8 @@ const utils = @import("utils.z");
 const Element = @import("element.zig").Element;
 const Union = @import("element.zig").Union;
 
+const JsObject = @import("../env.zig").JsObject;
+
 const Walker = @import("walker.zig").Walker;
 const WalkerDepthFirst = @import("walker.zig").WalkerDepthFirst;
 const WalkerChildren = @import("walker.zig").WalkerChildren;
@@ -318,10 +320,6 @@ pub const HTMLCollection = struct {
     cur_idx: ?u32 = undefined,
     cur_node: ?*parser.Node = undefined,
 
-    // array_like_keys is used to keep reference to array like interface implementation.
-    // the collection generates keys string which must be free on deinit.
-    array_like_keys: std.ArrayListUnmanaged([]u8) = .{},
-
     // start returns the first node to walk on.
     fn start(self: HTMLCollection) !?*parser.Node {
         if (self.root == null) return null;
@@ -403,13 +401,6 @@ pub const HTMLCollection = struct {
         return try Element.toInterface(e);
     }
 
-    pub fn indexed_get(self: *HTMLCollection, index: u32, has_value: *bool) !?Union {
-        return (try self._item(index)) orelse {
-            has_value.* = false;
-            return null;
-        };
-    }
-
     pub fn _namedItem(self: *const HTMLCollection, name: []const u8) !?Union {
         if (self.root == null) return null;
         if (name.len == 0) return null;
@@ -441,13 +432,6 @@ pub const HTMLCollection = struct {
         return null;
     }
 
-    pub fn named_get(self: *HTMLCollection, name: []const u8, has_value: *bool) !?Union {
-        return (try self._namedItem(name)) orelse {
-            has_value.* = false;
-            return null;
-        };
-    }
-
     fn item_name(elt: *parser.Element) !?[]const u8 {
         if (try parser.elementGetAttribute(elt, "id")) |v| {
             return v;
@@ -459,10 +443,17 @@ pub const HTMLCollection = struct {
         return null;
     }
 
-    pub fn deinit(self: *HTMLCollection, alloc: std.mem.Allocator) void {
-        for (self.array_like_keys_) |k| alloc.free(k);
-        self.array_like_keys.deinit(alloc);
-        self.matcher.deinit(alloc);
+    pub fn postAttach(self: *HTMLCollection, js_obj: JsObject) !void {
+        const len = try self.get_length();
+        for (0..len) |i| {
+            const node = try self.item(@intCast(i)) orelse unreachable;
+            const e = @as(*parser.Element, @ptrCast(node));
+            try js_obj.setIndex(@intCast(i), e);
+
+            if (try item_name(e)) |name| {
+                try js_obj.set(name, e);
+            }
+        }
     }
 };
 

src/browser/dom/implementation.zig

@@ -31,10 +31,10 @@ pub const DOMImplementation = struct {
 
     pub fn _createDocumentType(
         _: *DOMImplementation,
-        state: *SessionState,
         qname: []const u8,
         publicId: []const u8,
         systemId: []const u8,
+        state: *SessionState,
     ) !*parser.DocumentType {
         const allocator = state.arena;
         const cqname = try allocator.dupeZ(u8, qname);
@@ -51,10 +51,10 @@ pub const DOMImplementation = struct {
 
     pub fn _createDocument(
         _: *DOMImplementation,
-        state: *SessionState,
         namespace: ?[]const u8,
         qname: ?[]const u8,
         doctype: ?*parser.DocumentType,
+        state: *SessionState,
     ) !*parser.Document {
         const allocator = state.arena;
         var cnamespace: ?[:0]const u8 = null;

src/browser/dom/mutation_observer.zig

@@ -22,6 +22,7 @@ const parser = @import("../netsurf.zig");
 const SessionState = @import("../env.zig").SessionState;
 
 const Env = @import("../env.zig").Env;
+const JsObject = @import("../env.zig").JsObject;
 const NodeList = @import("nodelist.zig").NodeList;
 
 pub const Interfaces = .{
@@ -84,7 +85,7 @@ pub const MutationObserver = struct {
         return opt orelse .{};
     }
 
-    pub fn _observe(self: *MutationObserver, state: *SessionState, node: *parser.Node, options: ?MutationObserverInit) !void {
+    pub fn _observe(self: *MutationObserver, node: *parser.Node, options: ?MutationObserverInit, state: *SessionState) !void {
         const arena = state.arena;
         const o = try arena.create(Observer);
         o.* = .{
@@ -183,6 +184,11 @@ pub const MutationRecords = struct {
             return null;
         };
     }
+    pub fn postAttach(self: *const MutationRecords, js_obj: JsObject) !void {
+        if (self.first) |mr| {
+            try js_obj.set("0", mr);
+        }
+    }
 };
 
 pub const MutationRecord = struct {

src/browser/dom/node.zig

@@ -18,11 +18,6 @@
 
 const std = @import("std");
 
-const jsruntime = @import("jsruntime");
-const Case = jsruntime.test_utils.Case;
-const checkCases = jsruntime.test_utils.checkCases;
-const runScript = jsruntime.test_utils.runScript;
-
 const parser = @import("../netsurf.zig");
 const generate = @import("../../runtime/generate.zig");
 

src/browser/dom/nodelist.zig

@@ -20,10 +20,9 @@ const std = @import("std");
 
 const parser = @import("../netsurf.zig");
 
-const jsruntime = @import("jsruntime");
+const JsObject = @import("../env.zig").JsObject;
 const Callback = @import("../env.zig").Callback;
-const Case = jsruntime.test_utils.Case;
-const checkCases = jsruntime.test_utils.checkCases;
+const SessionState = @import("../env.zig").SessionState;
 
 const NodeUnion = @import("node.zig").Union;
 const Node = @import("node.zig").Node;
@@ -133,13 +132,22 @@ pub const NodeList = struct {
         return try Node.toInterface(n);
     }
 
-    // TODO entries() https://developer.mozilla.org/en-US/docs/Web/API/NodeList/entries
-    pub fn indexed_get(self: *const NodeList, index: u32, has_value: *bool) !?NodeUnion {
-        return (try self._item(index)) orelse {
-            has_value.* = false;
-            return null;
-        };
-    }
+    // This code works, but it's _MUCH_ slower than using postAttach. The benefit
+    // of this version, is that it's "live"..but we're talking many orders of
+    // magnitude slower.
+    //
+    // You can test it by commenting out `postAttach`, uncommenting this and
+    // running:
+    //    zig build wpt --  tests/wpt/dom/nodes/NodeList-static-length-getter-tampered-indexOf-1.html
+    //
+    // I think this _is_ the right way to do it, but I must be doing something
+    // wrong to make it so slow.
+    // pub fn indexed_get(self: *const NodeList, index: u32, has_value: *bool) !?NodeUnion {
+    //     return (try self._item(index)) orelse {
+    //         has_value.* = false;
+    //         return null;
+    //     };
+    // }
 
     pub fn _forEach(self: *NodeList, cbk: Callback) !void { // TODO handle thisArg
         for (self.nodes.items, 0..) |n, i| {
@@ -167,6 +175,15 @@ pub const NodeList = struct {
     pub fn _symbol_iterator(self: *NodeList) NodeListIterator {
         return self._values();
     }
+
+    // TODO entries() https://developer.mozilla.org/en-US/docs/Web/API/NodeList/entries
+    pub fn postAttach(self: *NodeList, js_obj: JsObject) !void {
+        const len = self.get_length();
+        for (0..len) |i| {
+            const node = try self._item(@intCast(i)) orelse unreachable;
+            try js_obj.setIndex(i, node);
+        }
+    }
 };
 
 const testing = @import("../../testing.zig");

src/browser/dom/text.zig

@@ -33,7 +33,7 @@ pub const Text = struct {
     pub const Self = parser.Text;
     pub const prototype = *CharacterData;
 
-    pub fn constructor(state: *const SessionState, data: ?[]const u8) !*parser.Text {
+    pub fn constructor(data: ?[]const u8, state: *const SessionState) !*parser.Text {
         return parser.documentCreateTextNode(
             parser.documentHTMLToDocument(state.document.?),
             data orelse "",