fix buffer ranges

Author: karlseguin

build.zig.zon

@@ -5,9 +5,9 @@
     .fingerprint = 0xda130f3af836cea0,
     .dependencies = .{
         .v8 = .{
-            .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/c25223900587005c9cf13f25e56a7e0be26a533c.tar.gz",
-            .hash = "v8-0.0.0-xddH6x_DAwBh0gSbFFv1fyiExhExXKzZpbmj5sFH4MRY",
+            .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/b51ed00390101b1fb9dd1ba4650c13f6586d0e24.tar.gz",
+            .hash = "v8-0.0.0-xddH68vFAwCYTTv4JjcgP7OcXSW7bv3sCKtaJ2SWXjR8",
         },
-        // .v8 = .{ .path = "../zig-v8-fork" }
+        //.v8 = .{ .path = "../zig-v8-fork" }
     },
 }

src/browser/encoding/TextDecoder.zig

@@ -19,6 +19,7 @@
 const std = @import("std");
 const log = @import("../../log.zig");
 
+const Env = @import("../env.zig").Env;
 const Page = @import("../page.zig").Page;
 
 // https://encoding.spec.whatwg.org/#interface-textdecoder
@@ -69,8 +70,8 @@ pub fn get_fatal(self: *const TextDecoder) bool {
 const DecodeOptions = struct {
     stream: bool = false,
 };
-pub fn _decode(self: *TextDecoder, input_: ?[]const u8, opts_: ?DecodeOptions, page: *Page) ![]const u8 {
-    var str = input_ orelse return "";
+pub fn _decode(self: *TextDecoder, str_: ?[]const u8, opts_: ?DecodeOptions, page: *Page) ![]const u8 {
+    var str = str_ orelse return "";
     const opts: DecodeOptions = opts_ orelse .{};
 
     if (self.stream.items.len > 0) {

src/runtime/js.zig

@@ -1226,56 +1226,56 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
                         if (force_u8 or js_value.isUint8Array() or js_value.isUint8ClampedArray()) {
                             if (byte_len == 0) return &[_]u8{};
                             const arr_ptr = @as([*]u8, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset..byte_len];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len];
                         }
                     },
                     i8 => {
                         if (js_value.isInt8Array()) {
                             if (byte_len == 0) return &[_]i8{};
                             const arr_ptr = @as([*]i8, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset..byte_len];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len];
                         }
                     },
                     u16 => {
                         if (js_value.isUint16Array()) {
                             if (byte_len == 0) return &[_]u16{};
                             const arr_ptr = @as([*]u16, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset .. byte_len / 2];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len / 2];
                         }
                     },
                     i16 => {
                         if (js_value.isInt16Array()) {
                             if (byte_len == 0) return &[_]i16{};
                             const arr_ptr = @as([*]i16, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset .. byte_len / 2];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len / 2];
                         }
                     },
                     u32 => {
                         if (js_value.isUint32Array()) {
                             if (byte_len == 0) return &[_]u32{};
                             const arr_ptr = @as([*]u32, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset .. byte_len / 4];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len / 4];
                         }
                     },
                     i32 => {
                         if (js_value.isInt32Array()) {
                             if (byte_len == 0) return &[_]i32{};
                             const arr_ptr = @as([*]i32, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset .. byte_len / 4];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len / 4];
                         }
                     },
                     u64 => {
                         if (js_value.isBigUint64Array()) {
                             if (byte_len == 0) return &[_]u64{};
                             const arr_ptr = @as([*]u64, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset .. byte_len / 8];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len / 8];
                         }
                     },
                     i64 => {
                         if (js_value.isBigInt64Array()) {
                             if (byte_len == 0) return &[_]i64{};
                             const arr_ptr = @as([*]i64, @ptrCast(@alignCast(data)));
-                            return arr_ptr[byte_offset .. byte_len / 8];
+                            return arr_ptr[byte_offset .. byte_offset + byte_len / 8];
                         }
                     },
                     else => {},

src/tests/encoding/decoder.html

@@ -47,11 +47,14 @@
 </script>
 
 <script id=slice>
-    const buffer = new ArrayBuffer(4);
-    const arr1 = new Uint8Array(buffer)
+    const buf1 = new ArrayBuffer(7);
+    const arr1 = new Uint8Array(buf1)
     arr1[0] = 80;
     arr1[1] = 81;
     arr1[2] = 82;
     arr1[3] = 83;
-    testing.expectEqual('QR', d3.decode(new Uint8Array(buffer, 1, 2)));
+    arr1[4] = 84;
+    arr1[5] = 85;
+    arr1[6] = 86;
+    testing.expectEqual('RST', d3.decode(new Uint8Array(buf1, 2, 3)));
 </script>