persistent context cleanup

Author: sjorsdonkers

build.zig.zon

@@ -13,10 +13,10 @@
             .hash = "tigerbeetle_io-0.0.0-ViLgxpyRBAB5BMfIcj3KMXfbJzwARs9uSl8aRy2OXULd",
         },
         .v8 = .{
-            .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/97bcfb61da8c97de1321d677a6727a927a9db9a4.tar.gz",
-            .hash = "v8-0.0.0-xddH69DoIADZ8YXZ_EIx_tKdQKEoGsgob_3_ZIi0O_nV",
+            .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/363e2899e6d782ad999edbfae048228871230467.tar.gz",
+            .hash = "v8-0.0.0-xddH6wHzIAARDy1uFvPqqBpTXzhlnEGDTuX9IAUQz3oU",
         },
-        //.v8 = .{ .path = "../zig-v8-fork" },
+        // .v8 = .{ .path = "../zig-v8-fork" },
         //.tigerbeetle_io = .{ .path = "../tigerbeetle-io" },
     },
 }

src/runtime/js.zig

@@ -264,10 +264,9 @@ pub fn Env(comptime S: type, comptime types: anytype) type {
             const templates = &self.templates;
 
             // The global FunctionTemplate (i.e. Window).
-            // env.generateClass(@field(types, s.name))
-            const globals = v8.Persistent(v8.FunctionTemplate).init(isolate, v8.FunctionTemplate.initDefault(isolate)).castToFunctionTemplate();
+            const globals = v8.FunctionTemplate.initDefault(isolate);
 
-            const global_template = v8.Persistent(v8.ObjectTemplate).init(isolate, globals.getInstanceTemplate()).castToObjectTemplate();
+            const global_template = globals.getInstanceTemplate();
             global_template.setInternalFieldCount(1);
             self.attachClass(Global, globals);
 
@@ -752,6 +751,7 @@ pub fn Env(comptime S: type, comptime types: anytype) type {
 
             // @intFromPtr of our Executor is stored in this context, so given
             // a context, we can always get the Executor back.
+            // This context is a persistent object. The persistent needs to be recovered and reset.
             context: v8.Context,
 
             // Because calls can be nested (i.e.a function calling a callback),
@@ -800,6 +800,8 @@ pub fn Env(comptime S: type, comptime types: anytype) type {
             fn deinit(self: *Executor) void {
                 if (self.scope != null) self.endScope();
                 self.context.exit();
+                var presistent_context = v8.Persistent(v8.Context).recoverCast(self.context);
+                presistent_context.deinit();
 
                 self._call_arena_instance.deinit();
                 self._scope_arena_instance.deinit();