quick experiment for re-using an isolate

Author: karlseguin

src/app.zig

@@ -1,6 +1,7 @@
 const std = @import("std");
 const Allocator = std.mem.Allocator;
 
+const Env = @import("browser/env.zig").Env;
 const Loop = @import("runtime/loop.zig").Loop;
 const HttpClient = @import("http/client.zig").Client;
 const Telemetry = @import("telemetry/telemetry.zig").Telemetry;
@@ -11,6 +12,7 @@ const log = std.log.scoped(.app);
 // Container for global state / objects that various parts of the system
 // might need.
 pub const App = struct {
+    env: *Env,
     loop: *Loop,
     config: Config,
     allocator: Allocator,
@@ -47,7 +49,11 @@ pub const App = struct {
 
         const app_dir_path = getAndMakeAppDir(allocator);
 
+        const env = try Env.init(allocator, .{});
+        errdefer env.deinit();
+
         app.* = .{
+            .env = env,
             .loop = loop,
             .allocator = allocator,
             .telemetry = undefined,
@@ -75,6 +81,7 @@ pub const App = struct {
         allocator.destroy(self.loop);
         self.http_client.deinit();
         self.notification.deinit();
+        self.env.deinit();
         allocator.destroy(self);
     }
 };

src/browser/browser.zig

@@ -45,15 +45,13 @@ pub const Browser = struct {
     pub fn init(app: *App) !Browser {
         const allocator = app.allocator;
 
-        const env = try Env.init(allocator, .{});
-        errdefer env.deinit();
 
         const notification = try Notification.init(allocator, app.notification);
         errdefer notification.deinit();
 
         return .{
             .app = app,
-            .env = env,
+            .env = app.env,
             .session = null,
             .allocator = allocator,
             .notification = notification,
@@ -66,7 +64,6 @@ pub const Browser = struct {
 
     pub fn deinit(self: *Browser) void {
         self.closeSession();
-        self.env.deinit();
         self.page_arena.deinit();
         self.session_arena.deinit();
         self.transfer_arena.deinit();