Skip to content

Commit fdb0e1e

Browse files
committed
cdp: send a warning for pierce parameter
1 parent c783be1 commit fdb0e1e

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/cdp/domains/dom.zig

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
// along with this program. If not, see <https://www.gnu.org/licenses/>.
1818

1919
const std = @import("std");
20+
const log = @import("../../log.zig");
2021
const Allocator = std.mem.Allocator;
2122
const Node = @import("../Node.zig");
2223
const css = @import("../../browser/dom/css.zig");
@@ -69,6 +70,10 @@ fn getDocument(cmd: anytype) !void {
6970
};
7071
const params = try cmd.params(Params) orelse Params{};
7172

73+
if (params.pierce) {
74+
log.warn(.cdp, "not implemented", .{ .feature = "DOM.getDocument: Not implemented pierce parameter" });
75+
}
76+
7277
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
7378
const page = bc.session.currentPage() orelse return error.PageNotLoaded;
7479
const doc = parser.documentHTMLToDocument(page.window.document);
@@ -310,7 +315,9 @@ fn describeNode(cmd: anytype) !void {
310315
pierce: bool = false,
311316
})) orelse return error.InvalidParams;
312317

313-
if (params.pierce) return error.NotImplemented;
318+
if (params.pierce) {
319+
log.warn(.cdp, "not implemented", .{ .feature = "DOM.describeNode: Not implemented pierce parameter" });
320+
}
314321
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
315322

316323
const node = try getNode(cmd.arena, bc, params.nodeId, params.backendNodeId, params.objectId);

0 commit comments

Comments
 (0)