Scope a request entry #575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
commented
Apr 25, 2025
| pub fn deinit(self: *Self) void { | ||
| if (self.isolated_world) |isolated_world| { | ||
| isolated_world.executor.endScope(); | ||
| isolated_world.executor.context.enter(); |
Contributor
Author
|
PR closed in favor of #578 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining a scop in Env, Executor and for a Page we enter and exit a scope upon receiving a call or a command.
The problem is that an Isolate has only 1 scope stack, but we have multiple contexts in flight at the same time.
This caused a problem where a page would close the scope, which would also remove the context that the isolatedworld put in there.
By closing all the scopes on exit of a command or call this should not be an issue.
Instead of storing globals in the Env scope, they are now persisted.
Also the context itself needs to persist, so we need to manually reset it when the context is deleted.