Improve usability of NodeWrapper #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NodeWrapper pattern attaches a Zig instance to a libdom Node. That works in isolation, but for 1 given node, we might want to attach different instances. For example, for an HTMLScriptElement we want to attach an `onError`, but for that same node viewed as an HTMLElement we want to a `CSSStyleDeclaration`. We can only have one. Currently, this code will crash if, for example, we create the embedded data as an HTMLScriptElement, then try to read the embedded data as an HTMLElement. This PR introduces dedicated state class. So if you want the onError property, you no longer ask the NodeWrapper for an HTMLSCriptElement. Instead, you ask for a storage/HTMLElement. Nothing fancy here, just memory-inefficient optional fields. If it gets out of hand, we'll think of something more clever.
sjorsdonkers
approved these changes
Jun 4, 2025
Contributor
sjorsdonkers
left a comment
sjorsdonkers
left a comment
There was a problem hiding this comment.
Could consider not making the optimization of defining multiple State structs and just use 1 for everything. So combine Document and HtmlElement state structs as well for now.
Collaborator
Author
Actually, I think we have no choice. With the way I did it, we'll still run into the same problem as soon as we need something on both HTMLElement and Element or Node. I've added a global |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodeWrapper pattern attaches a Zig instance to a libdom Node. That works in isolation, but for 1 given node, we might want to attach different instances.
For example, for an HTMLScriptElement we want to attach an
onError, but for that same node viewed as an HTMLElement we want to aCSSStyleDeclaration. We can only have one. Currently, this code will crash if, for example, we create the embedded data as an HTMLScriptElement, then try to read the embedded data as an HTMLElement.This PR introduces dedicated state class. So if you want the onError property, you no longer ask the NodeWrapper for an HTMLSCriptElement. Instead, you ask for a storage/HTMLElement.
Nothing fancy here, just memory-inefficient optional fields. If it gets out of hand, we'll think of something more clever.