Skip to content

jsValueToZig for fixed sized arrays #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2025
Merged

jsValueToZig for fixed sized arrays #1019

merged 4 commits into from
Sep 8, 2025

Conversation

@sjorsdonkers
Copy link
Contributor

@sjorsdonkers sjorsdonkers commented Sep 5, 2025 •
edited
Loading

  • Only accepts the value if the Js array size matches exactly

Note: tests failing due to fetch branch issue

@sjorsdonkers sjorsdonkers requested a review from mookums September 5, 2025 14:38
karlseguin
karlseguin reviewed Sep 5, 2025
View reviewed changes
@sjorsdonkers sjorsdonkers marked this pull request as draft September 5, 2025 14:58
karlseguin
karlseguin reviewed Sep 5, 2025
View reviewed changes
@sjorsdonkers sjorsdonkers marked this pull request as ready for review September 5, 2025 15:20
@mookums mookums merged commit 340b8a2 into fetch Sep 8, 2025
17 of 19 checks passed
@mookums mookums deleted the jsValueToZig-for-fixed-sized-arrays branch September 8, 2025 03:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karlseguin karlseguin karlseguin left review comments

@mookums mookums Awaiting requested review from mookums

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjorsdonkers @karlseguin @mookums