Remove CDP FrameId #460
Merged
Remove CDP FrameId #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if FrameId is related to an <iframe>, and whether each Page has 1 implicit "frame". But, playwright seems to treat frameId and targetId as interchangeable, and chrome seems to agree (at leas to some degree); chrome will return a targetId and reuse that value for the frameId. So the simplest solution is just to remove our concept of a frameId and use targetId exclusively. This doesn't seem to cause any issues with puppeteer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if FrameId is related to an <iframe>, and whether each Page has 1 implicit "frame". But, playwright seems to treat frameId and targetId as interchangeable, and chrome seems to agree (at leas to some degree); chrome will return a targetId and reuse that value for the frameId.
So the simplest solution is just to remove our concept of a frameId and use targetId exclusively. This doesn't seem to cause any issues with puppeteer.