Performance now #636
Merged
Performance now #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
force-pushed
the
performance_now
branch
from
33311ef to
d6eb6d2
Compare
karlseguin
reviewed
May 13, 2025
karlseguin
reviewed
May 13, 2025
| // Monotonically increasing | ||
| var now = perf._now(); | ||
| while (now <= 0) { // Loop for now to not be 0 | ||
| try testing.expectEqual(now, 0); |
Collaborator
There was a problem hiding this comment.
Parameters are swapped, it's expected, actual /shrug.
Contributor
Author
There was a problem hiding this comment.
I'll take this change into the next PR
| } | ||
|
|
||
| pub fn get_timeOrigin(self: *const Performance) f64 { | ||
| const is_posix = switch (@import("builtin").os.tag) { // From std.time.zig L125 |
Collaborator
There was a problem hiding this comment.
It's fine, but just FYI, build.zig blocks any builds that aren't on linux or macos. There are a few places, like browser.zig timestamp function, which treat anything else as unreachable.
Contributor
Author
There was a problem hiding this comment.
Yea, this is ugly. I wanted to just use the is_posix constant in time.zig, but that is not pub for some reason.
Then wanted to just check if @TypeOf(std.time.Instant.timestamp) == i64 but also:
const ts_field = @typeInfo(std.time.Instant).@"struct".fields[0];
if (!std.mem.eql(u8, ts_field.name, "timestamp")) @compileError(ts_field.name);
const is_i64 = ts_field.type == i64;
Does not seem to work ..
Collaborator
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of 2 interfaces of performance
https://developer.mozilla.org/en-US/docs/Web/API/Performance/timeOrigin
https://developer.mozilla.org/en-US/docs/Web/API/Performance/now
many still TODO
Performance implementation as part of Window, WorkerGlobalScope not implemented.
These APIs are implemented as part of making Playwright click work.