scrollIntoViewIfNeeded, getContentQuads, innerWidth/Heigh #638
+125
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
force-pushed
the
DOM-scoll-and-quads
branch
from
60c2198 to
85f83e8
Compare
sjorsdonkers
force-pushed
the
DOM-scoll-and-quads
branch
from
85f83e8 to
4cb14cd
Compare
sjorsdonkers
commented
May 14, 2025
| } | ||
|
|
||
| pub fn _scrollIntoViewIfNeeded(_: *parser.Element, center_if_needed: ?bool) void { | ||
| _ = center_if_needed; |
Contributor
Author
There was a problem hiding this comment.
We could register the element in the renderer..
sjorsdonkers
changed the title
karlseguin
reviewed
May 14, 2025
| fn getNode(arena: Allocator, browser_context: anytype, node_id: ?Node.Id, backend_node_id: ?Node.Id, object_id: ?[]const u8) !*Node { | ||
| const input_node_id = node_id orelse backend_node_id; | ||
| if (input_node_id) |input_node_id_| { | ||
| return browser_context.node_registry.lookup_by_id.get(input_node_id_) orelse return error.NodeNotFound; |
Collaborator
There was a problem hiding this comment.
Would a getById function on registry be useful?
Contributor
Author
There was a problem hiding this comment.
To reduce: .lookup_ _. I personally am not a fan of convenience functions.
| const parser_node = try bc.inspector.getNodePtr(cmd.arena, params.objectId.?); | ||
| const node = try bc.node_registry.register(@ptrCast(parser_node)); | ||
| return cmd.sendResult(.{ .node = bc.nodeWriter(node, .{}) }, .{}); | ||
| const parser_node = try browser_context.inspector.getNodePtr(arena, object_id_); |
Collaborator
There was a problem hiding this comment.
I don't really know what getNodePtr is doing. It's ok that its memory (from the arena) will be gone after this function returns?
Contributor
Author
There was a problem hiding this comment.
Only the object_group may be returned on the allocator, which is not used. (Arena is also used for temporary error strings, but not returned (returned as error enum))
sjorsdonkers
force-pushed
the
DOM-scoll-and-quads
branch
from
93f51de to
f74647c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element.scrollIntoViewIfNeededDOM.scrollIntoViewIfNeededDOM.getContentQuadsinnerHeightinnerWidth