Playwright support disclaimer #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| See [benchmark details](https://github.com/lightpanda-io/demo)._ | ||
|
|
||
| > **Playwright support disclaimer:** | ||
| > Due to the nature of Playwright, a script that works with the current version of the browser may not function correctly with a future version. Playwright uses an intermediate JavaScript layer that selects an execution strategy based on the browser's available features. If LightPanda adds a new [Web API](https://developer.mozilla.org/en-US/docs/Web/API), Playwright may choose to execute different code for the same script. This new code path could attempt to use features that are not yet implemented. Puppeteer has proven to be more resilient to changes in the browser. |
Member
There was a problem hiding this comment.
Some comments:
- why do you use the blockquote
>char? It's intentional? - I would like to remove "Puppeteer has proven to be more resilient to changes in the browser." part. I'm not sure it's really helpful.
- I would add 2 things: 1 saying we make the effort to add compatibility tests, but we can't cover all scenarios + asking user to create issue giving a previous version which was working.
Contributor
Author
There was a problem hiding this comment.
- I made it a footnote, so it is now linked to the bottom of the page.
- Removed puppeteer
- Added 2 things
sjorsdonkers
force-pushed
the
playwright-support-disclaimer
branch
from
b7dca5c to
8b74d96
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a disclaimer on Playwright to make sure user's are aware that scripts may break as correctly implemented features get added to the browser.