Attribute.set_value uses element, if possible #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only when setAttribute is called directly on the element, does libdom raise a `DOMAttrModified` event (which MutationObserver uses). From what I can tell, libdom's element set attribute _does_ rely on the underlying attribute set value, so the behavior should be pretty close, it just does extra things on top of that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only when setAttribute is called directly on the element, does libdom raise a
DOMAttrModifiedevent (which MutationObserver uses).From what I can tell, libdom's element set attribute does rely on the underlying attribute set value, so the behavior should be pretty close, it just does extra things on top of that.