Repeated Registering of Listener #912
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Jul 23, 2025
| // remove any existing listener, so it should be impossible to get null | ||
| // from this function call. | ||
| const eh = (try EventHandler.register(alloc, target, typ, listener, null)) orelse unreachable; | ||
| const eh = (try EventHandler.register(alloc, target, typ, listener, null)) orelse return null; |
Collaborator
There was a problem hiding this comment.
Do we understand how this is happening? I tend to agree with the comment. This is only called from a set_xyz and all the set_xyz should unregister the existing callback, so how is EventHandler.register returning null?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for repeated registering of a listener. This fixes
old.reddit.comand allow for both the body and the comments to be properly fetched.