Skip to content

Commit 044c6bf

Browse files
committed
Apply suggestions from code review
1 parent 4506bbb commit 044c6bf

File tree

1 file changed

+2
-21
lines changed

1 file changed

+2
-21
lines changed

README.md

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -164,12 +164,12 @@ Lightpanda browser, but the code is not publicly available yet.
164164

165165
### Running the benchmark
166166

167-
The `playwright/chrome.js` benchmark accepts multiple env vars to be configured.
167+
The `playwright/cdp.js` benchmark accepts multiple env vars to be configured.
168168
* `BROWSER_PATH` is the path to your browser implementing the CDP protocol. It can be either the path to a local binary or an URL (host:port) of a running browser. Default value is empty, which will launch the Google Chrome installed through Playwright.
169169
* `BASE_URL` is the base url of the running web reser to request, by default `http://127.0.0.1:1234`.
170170
* `RUNS` is the number of pages loaded by the benchmark, default is `100`.
171171

172-
`npm run bench-chrome` starts a playwright process, load a Google Chrome
172+
`npm run bench-cdp` starts a playwright process
173173
instance and load the page to extract data 100 times.
174174

175175
```console
@@ -198,22 +198,3 @@ max run duration (ms) 323
198198
```
199199

200200
![aws.m5 Playwright with Google Chrome](./img/aws_m5_playwright_chrome.png)
201-
202-
**Lightpanda***
203-
204-
Current version (commit X).
205-
206-
```console
207-
$ npm run bench-cdp
208-
209-
> [email protected] bench-chrome
210-
> node playwright/chrome.js
211-
212-
................................................................................
213-
....................
214-
total runs 100
215-
total duration (ms) 18792
216-
avg run duration (ms) 184
217-
min run duration (ms) 168
218-
max run duration (ms) 323
219-
```

0 commit comments

Comments
 (0)