Skip to content

Commit d82972f

Browse files
committed
upgrade puppeteer to 24
1 parent af7badd commit d82972f

File tree

3 files changed

+57
-138
lines changed

3 files changed

+57
-138
lines changed

package-lock.json

Lines changed: 49 additions & 130 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@
2222
"homepage": "https://lightpanda.io",
2323
"dependencies": {
2424
"playwright": "^1.42.1",
25-
"puppeteer-core": "^22.15.0"
25+
"puppeteer-core": "^24.10.1"
2626
}
2727
}

puppeteer/cookies.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,28 +22,28 @@ const url = process.env.URL ? process.env.URL : 'http://127.0.0.1:1234/campfire-
2222
const browser = await puppeteer.connect({
2323
browserWSEndpoint: browserAddress,
2424
});
25-
2625
// The rest of your script remains the same.
2726
const context = await browser.createBrowserContext();
2827
const page = await context.newPage();
2928

3029
const relevant_cookie = {name: 'left', value: 'right', url: "http://127.0.0.1:1234/"};
3130
const irrelevant_cookie = {name: 'uo', value: 'down', url: "https://lightpanda.io/"};
32-
33-
await page.setCookie(relevant_cookie, irrelevant_cookie);
31+
await context.setCookie(relevant_cookie, irrelevant_cookie);
3432

3533
await page.goto(url, {waitUntil: 'load'});
3634

37-
const found_cookies = await page.cookies();
35+
const found_cookies = await context.cookies();
3836
for (const cookie of found_cookies) {
3937
const { name, ...details } = cookie
4038
console.log(`Cookie: ${name} = ${JSON.stringify(details)}`);
4139
}
42-
43-
if (found_cookies.length != 1) {
40+
if (found_cookies.length != 2) {
4441
throw new Error("Wrong number of cookies found");
4542
}
46-
if (found_cookies[0].name !== relevant_cookie.name || found_cookies[0].value !== relevant_cookie.value) {
43+
44+
context.deleteCookie(irrelevant_cookie);
45+
const found_cookies2 = await context.cookies();
46+
if (found_cookies2.length != 1 && found_cookies2[0].name !== relevant_cookie.name || found_cookies2[0].value !== relevant_cookie.value) {
4747
throw new Error("Cookie does not match the expected values");
4848
}
4949

0 commit comments

Comments
 (0)