playwright: use BROWSER_ADDRESS env var only

and remove the BROWSER_PATH

Author: krichprollsch

README.md

@@ -165,15 +165,15 @@ Lightpanda browser, but the code is not publicly available yet.
 ### Running the benchmark
 
 The `playwright/cdp.js` benchmark accepts multiple env vars to be configured.
-* `BROWSER_PATH` is the path to your browser implementing the CDP protocol. It can be either the path to a local binary or an URL (host:port) of a running browser. Default value is empty, which will launch the Google Chrome installed through Playwright.
+* `BROWSER_ADDRESS` is the address of the running browser listening the CDP protocol, by default `http://127.0.0.1:9222`.
 * `BASE_URL` is the base url of the running web reser to request, by default `http://127.0.0.1:1234`.
 * `RUNS` is the number of pages loaded by the benchmark, default is `100`.
 
 `npm run bench-cdp` starts a playwright process
 instance and load the page to extract data 100 times.
 
 ```console
-$ BROWSER_PATH=127.0.0.1:9222 npm run bench-cdp
+$ npm run bench-cdp
 ```
 
 ### Results
@@ -182,6 +182,12 @@ $ BROWSER_PATH=127.0.0.1:9222 npm run bench-cdp
 
 We use Google Chrome version 123.0.6312.105.
 
+You have to start the browser first.
+```console
+$ google-chrome --headless=new --disable-gpu --remote-debugging-port=9222
+```
+
+Then you can run the benchmark.
 ```console
 $ npm run bench-cdp
 

package.json

@@ -5,7 +5,6 @@
   "description": "Lightpanda browser demo",
   "main": "index.js",
   "scripts": {
-    "install-chrome": "npx playwright install chrome",
     "ws": "go run ws/main.go",
     "bench-cdp": "node playwright/cdp.js"
   },

playwright/cdp.js

@@ -11,40 +11,12 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-import fs from 'fs';
 
 // Import the Chromium browser into our scraper.
 import { chromium } from 'playwright';
 
-// check if browser path if a local path or an URL
-let browserPath = process.env.BROWSER_PATH;
-let networkPath;
-if (browserPath) {
-
-    // not local path
-    if (!fs.existsSync(browserPath)) {
-	if (!browserPath.startsWith("http://")) {
-	    browserPath = "http://" + browserPath
-	}
-	const url = new URL(browserPath);
-	networkPath = url.host;
-    }
-}
-
-// options passed to the browser
-let browserOptions = {};
-if (!networkPath) {
-
-    // chrome browser path
-    if (browserPath) {
-	browserOptions.executablePath = browserPath;
-    }
-
-    // headless
-    if (process.env.HEADLESS) {
-	browserOptions.headless = process.env.HEADLESS === 'true';
-    }
-}
+// browserAddress
+const browserAddress = process.env.BROWSER_ADDRESS ? process.env.BROWSER_ADDRESS : 'http://127.0.0.1:9222';
 
 // web serveur url
 const baseURL = process.env.BASE_URL ? process.env.BASE_URL : 'http://127.0.0.1:1234';
@@ -57,32 +29,9 @@ const gstart = process.hrtime.bigint();
 // store all run durations
 let metrics = [];
 
-let browser;
-if (networkPath) {
-
-    // Connect to an existing browser
-    console.log("Connection to browser on " + networkPath + "...");
-
-    const resp = await fetch("http://" + networkPath + "/json/version");
-    const version = await resp.json()
-    const wsURL = version.webSocketDebuggerUrl;
-
-    browser = await chromium.connectOverCDP(wsURL);
-
-} else {
-
-    // Launching a new browser
-    if (browserPath) {
-	console.log("Launching browser " + browserPath);
-    } else {
-	console.log("Launching browser");
-    }
-    
-    // We use headless: false
-    // to be able to watch the browser window.
-    browser = await chromium.launch(browserOptions);
-
-}
+// Connect to an existing browser
+console.log("Connection to browser on " + browserAddress);
+const browser = await chromium.connectOverCDP(browserAddress);
 
 for (var run = 1; run<=runs; run++) {