Merge pull request #288 from lightpanda-io/macos-x86_64

build: accept macos x86_64

Author: krichprollsch

.github/actions/install/action.yml

@@ -51,7 +51,9 @@ runs:
 
         wget -O ${{ inputs.cache-dir }}/v8/libc_v8.a https://github.com/lightpanda-io/zig-v8-fork/releases/download/${{ inputs.zig-v8 }}/libc_v8_${{ inputs.v8 }}_${{ inputs.os }}_${{ inputs.arch }}.a
 
-    - run: sudo apt-get install -yq libglib2.0-dev
+    - name: Install apt deps
+      if: ${{ inputs.os == 'linux' }}
+      run: sudo apt-get install -yq libglib2.0-dev
       shell: bash
 
     - name: install v8

.github/workflows/zig-test.yml

@@ -87,3 +87,75 @@ jobs:
 
       - name: zig build test
         run: zig build test -Dengine=v8
+
+  zig-test-macos-x86_64:
+    env:
+      ARCH: x86_64
+      OS: macos
+
+    # Don't run the CI with draft PR.
+    if: github.event.pull_request.draft == false
+
+    runs-on: macos-13
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          submodules: true
+
+      - uses: ./.github/actions/install
+        with:
+          os: ${{env.OS}}
+          arch: ${{env.ARCH}}
+
+      - name: zig build test
+        run: zig build test -Dengine=v8
+
+  zig-test-macos-aarch64:
+    env:
+      ARCH: aarch64
+      OS: macos
+
+    # Don't run the CI with draft PR.
+    if: github.event.pull_request.draft == false
+
+    runs-on: macos-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          submodules: true
+
+      - uses: ./.github/actions/install
+        with:
+          os: ${{env.OS}}
+          arch: ${{env.ARCH}}
+
+      - name: zig build test
+        run: zig build test -Dengine=v8
+
+  zig-test-linux-aarch64:
+    env:
+      ARCH: aarch64
+      OS: linux
+
+    # Don't run the CI with draft PR.
+    if: github.event.pull_request.draft == false
+
+    runs-on: ubuntu-24.04-arm
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          submodules: true
+
+      - uses: ./.github/actions/install
+        with:
+          os: ${{env.OS}}
+          arch: ${{env.ARCH}}
+
+      - name: zig build test
+        run: zig build test -Dengine=v8

build.zig

@@ -198,10 +198,6 @@ pub fn packages(comptime vendor_path: []const u8) type {
                     break :blk;
                 },
                 .macos => blk: {
-                    if (arch != .aarch64) {
-                        std.debug.print("only aarch64 are supported on macos builds\n", .{});
-                        return error.ArchNotSupported;
-                    }
                     break :blk;
                 },
                 else => return error.OsNotSupported,