Skip to content

Commit 30cf629

Browse files
committed
remove useless cxx_use_ld argument
The argument cxx_use_ld generated a warning and wasn't used. ``` WARNING at the command-line "--args":1:132: Build argument has no effect. target_os="linux" target_cpu="x64" is_debug=false symbol_level=0 is_official_build=false v8_enable_handle_zapping=false cxx_use_ld="lld" ^---- The variable "cxx_use_ld" was set as a build argument but never appeared in a declare_args() block in any buildfile. To view all possible args, run "gn args --list <out_dir>" The build continued as if that argument was unspecified. ```
1 parent 21331e7 commit 30cf629

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

build.zig

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ fn createV8_Build(b: *std.Build, target: std.Build.ResolvedTarget, mode: std.bui
231231
try host_zig_cxx.append("-Wno-error=builtin-assume-aligned-alignment");
232232

233233
try gn_args.append("use_zig_tc=true");
234-
try gn_args.append("cxx_use_ld=\"zig ld.lld\"");
235234

236235
// Build zig cc strings.
237236
var arg = b.fmt("zig_cc=\"{s}\"", .{try std.mem.join(b.allocator, " ", zig_cc.items)});
@@ -243,9 +242,6 @@ fn createV8_Build(b: *std.Build, target: std.Build.ResolvedTarget, mode: std.bui
243242
arg = b.fmt("host_zig_cxx=\"{s}\"", .{try std.mem.join(b.allocator, " ", host_zig_cxx.items)});
244243
try gn_args.append(arg);
245244
} else {
246-
if (builtin.os.tag != .windows) {
247-
try gn_args.append("cxx_use_ld=\"lld\"");
248-
}
249245
if (target.result.os.tag == .linux and target.result.cpu.arch == .aarch64) {
250246
// On linux aarch64, we can not use the clang version provided in v8 sources
251247
// as it's built for x86_64 (TODO: using Rosetta2 for Linux VM on Apple Silicon?)

0 commit comments

Comments
 (0)