Merge pull request #36 from lightpanda-io/objectunwrap

Expose inspector session wrapObject

Author: krichprollsch

src/binding.cpp

@@ -5,6 +5,7 @@
 #include "include/v8-inspector.h"
 #include "include/v8.h"
 #include "src/api/api.h"
+#include "src/inspector/protocol/Runtime.h"
 
 #include "inspector.h"
 
@@ -1549,9 +1550,12 @@ void v8__base__SetDcheckFunction(void (*func)(const char*, int, const char*)) {
 
 // Utils
 
+static inline v8_inspector::StringView toStringView(const char *str, size_t length) {
+    auto* stringView = reinterpret_cast<const uint8_t*>(str);
+    return { stringView, length };
+}
 static inline v8_inspector::StringView toStringView(const std::string &str) {
-  auto* stringView = reinterpret_cast<const uint8_t*>(str.c_str());
-  return { stringView, str.length() };
+    return toStringView(str.c_str(), str.length());
 }
 
 static inline std::string fromStringView(v8::Isolate* isolate, const v8_inspector::StringView stringView) {
@@ -1621,12 +1625,25 @@ void v8_inspector__Session__DELETE(v8_inspector::V8InspectorSession* self) {
 void v8_inspector__Session__dispatchProtocolMessage(
     v8_inspector::V8InspectorSession *session, v8::Isolate *isolate,
     const char *msg, int msg_len) {
-  std::string message;
-  message.assign(msg, msg_len);
-  auto str_view = toStringView(message);
+  auto str_view = toStringView(msg, msg_len);
   session->dispatchProtocolMessage(str_view);
 }
 
+v8_inspector::protocol::Runtime::API::RemoteObject* v8_inspector__Session__wrapObject(
+    v8_inspector::V8InspectorSession *session, v8::Isolate *isolate,
+    const v8::Context* ctx, const v8::Value* val,
+    const char *grpname, int grpname_len, bool generatepreview) {
+  auto sv_grpname = toStringView(grpname, grpname_len);
+  auto remote_object = session->wrapObject(ptr_to_local(ctx), ptr_to_local(val), sv_grpname, generatepreview);
+  return remote_object.release();
+}
+
+// RemoteObject
+
+void v8_inspector__RemoteObject__DELETE(v8_inspector::protocol::Runtime::API::RemoteObject* self) {
+  delete self;
+}
+
 // InspectorChannel
 
 v8_inspector__Channel__IMPL * v8_inspector__Channel__IMPL__CREATE(v8::Isolate *isolate) {

src/binding.h

@@ -993,11 +993,19 @@ const Context* v8_inspector__Client__IMPL__valueSubtype(
 const Context* v8_inspector__Client__IMPL__descriptionForValueSubtype(
     InspectorClientImpl* self, Context context, Value value);
 
+
+// RemoteObject
+typedef struct RemoteObject RemoteObject;
+
 // InspectorSession
 
 typedef struct InspectorSession InspectorSession;
-void v8_inspector__Session__DELETE(Inspector *self);
+void v8_inspector__Session__DELETE(InspectorSession *self);
 void v8_inspector__Session__dispatchProtocolMessage(InspectorSession *session, Isolate *isolate, const char* msg, usize msg_len);
+RemoteObject* v8_inspector__Session__wrapObject(
+    InspectorSession *session, Isolate *isolate,
+    const Context* ctx, const Value* val,
+    const char *grpname, int grpname_len, bool generatepreview);
 
 // Inspector
 typedef struct Inspector Inspector;

src/v8.zig

@@ -2551,7 +2551,6 @@ pub export fn v8_inspector__Client__IMPL__ensureDefaultContextInGroup(
     return inspector.ctx_handle;
 }
 
-
 usingnamespace if (@import("default_exports").inspector_subtype) struct {
     pub export fn v8_inspector__Client__IMPL__valueSubtype(
         _: *c.InspectorClientImpl,
@@ -2669,4 +2668,27 @@ pub const InspectorSession = struct {
             msg.len,
         );
     }
+
+    pub fn wrapObject(self: InspectorSession, isolate: Isolate, ctx: Context, val: Value, grpname: []const u8, generatepreview: bool) !RemoteObject {
+        const remote_obj = c.v8_inspector__Session__wrapObject(
+            self.handle,
+            isolate.handle,
+            ctx.handle,
+            val.handle,
+            grpname.ptr,
+            grpname.len,
+            generatepreview,
+        );
+        if (remote_obj) {
+            return RemoteObject{ .handle = remote_obj };
+        } else return error.JsException;
+    }
+};
+
+pub const RemoteObject = struct {
+    handle: *c.RemoteObject,
+
+    pub fn deinit(self: *RemoteObject) void {
+        c.v8_inspector__RemoteObject__DELETE(self.handle);
+    }
 };