Skip to content

Commit 4d70430

Browse files
committed
correct cpp side
1 parent 826eb22 commit 4d70430

File tree

1 file changed

+12
-24
lines changed

1 file changed

+12
-24
lines changed

src/binding.cpp

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1736,11 +1736,9 @@ void v8_inspector__RemoteObject__DELETE(v8_inspector::protocol::Runtime::RemoteO
17361736
}
17371737

17381738
// RemoteObject - Type
1739-
CZigString v8_inspector__RemoteObject__getType(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator) {
1739+
bool v8_inspector__RemoteObject__getType(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator, CZigString &out_type) {
17401740
auto str = self->getType();
1741-
CZigString result;
1742-
allocString(toStringView(str), allocator, result);
1743-
return result;
1741+
return allocString(toStringView(str), allocator, out_type);
17441742
}
17451743
void v8_inspector__RemoteObject__setType(v8_inspector::protocol::Runtime::RemoteObject* self, CZigString type) {
17461744
self->setType(v8_inspector::String16::fromUTF8(type.ptr, type.len));
@@ -1750,11 +1748,9 @@ void v8_inspector__RemoteObject__setType(v8_inspector::protocol::Runtime::Remote
17501748
bool v8_inspector__RemoteObject__hasSubtype(v8_inspector::protocol::Runtime::RemoteObject* self) {
17511749
return self->hasSubtype();
17521750
}
1753-
CZigString v8_inspector__RemoteObject__getSubtype(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator) {
1751+
bool v8_inspector__RemoteObject__getSubtype(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator, CZigString &subtype) {
17541752
auto str = self->getSubtype(DEFAULT_STRING);
1755-
CZigString result;
1756-
allocString(toStringView(str), allocator, result);
1757-
return result;
1753+
return allocString(toStringView(str), allocator, subtype);
17581754
}
17591755
void v8_inspector__RemoteObject__setSubtype(v8_inspector::protocol::Runtime::RemoteObject* self, CZigString subtype) {
17601756
self->setSubtype(v8_inspector::String16::fromUTF8(subtype.ptr, subtype.len));
@@ -1764,11 +1760,9 @@ void v8_inspector__RemoteObject__setSubtype(v8_inspector::protocol::Runtime::Rem
17641760
bool v8_inspector__RemoteObject__hasClassName(v8_inspector::protocol::Runtime::RemoteObject* self) {
17651761
return self->hasClassName();
17661762
}
1767-
CZigString v8_inspector__RemoteObject__getClassName(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator) {
1763+
bool v8_inspector__RemoteObject__getClassName(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator, CZigString &className) {
17681764
auto str = self->getClassName(DEFAULT_STRING);
1769-
CZigString result;
1770-
allocString(toStringView(str), allocator, result);
1771-
return result;
1765+
return allocString(toStringView(str), allocator, className);
17721766
}
17731767
void v8_inspector__RemoteObject__setClassName(v8_inspector::protocol::Runtime::RemoteObject* self, CZigString className) {
17741768
self->setClassName(v8_inspector::String16::fromUTF8(className.ptr, className.len));
@@ -1789,11 +1783,9 @@ void v8_inspector__RemoteObject__setValue(v8_inspector::protocol::Runtime::Remot
17891783
bool v8_inspector__RemoteObject__hasUnserializableValue(v8_inspector::protocol::Runtime::RemoteObject* self) {
17901784
return self->hasUnserializableValue();
17911785
}
1792-
CZigString v8_inspector__RemoteObject__getUnserializableValue(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator) {
1786+
bool v8_inspector__RemoteObject__getUnserializableValue(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator, CZigString &unserializableValue) {
17931787
auto str = self->getUnserializableValue(DEFAULT_STRING);
1794-
CZigString result;
1795-
allocString(toStringView(str), allocator, result);
1796-
return result;
1788+
return allocString(toStringView(str), allocator, unserializableValue);
17971789
}
17981790
void v8_inspector__RemoteObject__setUnserializableValue(v8_inspector::protocol::Runtime::RemoteObject* self, CZigString unserializableValue) {
17991791
self->setUnserializableValue(v8_inspector::String16::fromUTF8(unserializableValue.ptr, unserializableValue.len));
@@ -1803,11 +1795,9 @@ void v8_inspector__RemoteObject__setUnserializableValue(v8_inspector::protocol::
18031795
bool v8_inspector__RemoteObject__hasDescription(v8_inspector::protocol::Runtime::RemoteObject* self) {
18041796
return self->hasDescription();
18051797
}
1806-
CZigString v8_inspector__RemoteObject__getDescription(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator) {
1798+
bool v8_inspector__RemoteObject__getDescription(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator, CZigString &description) {
18071799
auto str = self->getDescription(DEFAULT_STRING);
1808-
CZigString result;
1809-
allocString(toStringView(str), allocator, result);
1810-
return result;
1800+
return allocString(toStringView(str), allocator, description);
18111801
}
18121802
void v8_inspector__RemoteObject__setDescription(v8_inspector::protocol::Runtime::RemoteObject* self, CZigString description) {
18131803
self->setDescription(v8_inspector::String16::fromUTF8(description.ptr, description.len));
@@ -1829,11 +1819,9 @@ bool v8_inspector__RemoteObject__hasObjectId(v8_inspector::protocol::Runtime::Re
18291819
return self->hasObjectId();
18301820
}
18311821

1832-
CZigString v8_inspector__RemoteObject__getObjectId(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator) {
1822+
bool v8_inspector__RemoteObject__getObjectId(v8_inspector::protocol::Runtime::RemoteObject* self, const void* allocator, CZigString &objectId) {
18331823
auto str = self->getObjectId(DEFAULT_STRING);
1834-
CZigString result;
1835-
allocString(toStringView(str), allocator, result);
1836-
return result;
1824+
return allocString(toStringView(str), allocator, objectId);
18371825
}
18381826
void v8_inspector__RemoteObject__setObjectId(v8_inspector::protocol::Runtime::RemoteObject* self, CZigString objectId) {
18391827
self->setObjectId(v8_inspector::String16::fromUTF8(objectId.ptr, objectId.len));

0 commit comments

Comments
 (0)