Skip to content

Commit 57aa2aa

Browse files
authored
Merge pull request #69 from lightpanda-io/v8_revision
add revision to generated build files
2 parents 4809111 + 605650c commit 57aa2aa

File tree

1 file changed

+9
-28
lines changed

1 file changed

+9
-28
lines changed

.github/workflows/build-release.yml

Lines changed: 9 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ permissions:
1212

1313
env:
1414
ZIG_VERSION: 0.14.0
15+
V8_REVISION: 13.6.233.8
1516

1617
jobs:
1718
build-x86_64-linux:
@@ -30,24 +31,19 @@ jobs:
3031
submodules: recursive
3132
fetch-depth: 0
3233

33-
- name: Read version
34-
id: read-version
35-
run: |
36-
echo "version=`cat V8_REVISION`" >> "$GITHUB_OUTPUT"
37-
3834
- run: |
3935
sudo apt-get update
4036
sudo apt-get install -yq libglib2.0-dev
4137
4238
- run: zig build get-v8
4339
- run: zig build -Doptimize=ReleaseSafe build-v8
44-
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
40+
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a
4541

4642
- name: Upload the build
4743
uses: ncipollo/release-action@v1
4844
with:
4945
allowUpdates: true
50-
artifacts: libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
46+
artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a
5147

5248
build-aarch64-macos:
5349
env:
@@ -69,20 +65,15 @@ jobs:
6965
submodules: recursive
7066
fetch-depth: 0
7167

72-
- name: Read version
73-
id: read-version
74-
run: |
75-
echo "version=`cat V8_REVISION`" >> "$GITHUB_OUTPUT"
76-
7768
- run: zig build get-v8
7869
- run: zig build -Doptimize=ReleaseSafe build-v8
79-
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
70+
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a
8071

8172
- name: Upload the build
8273
uses: ncipollo/release-action@v1
8374
with:
8475
allowUpdates: true
85-
artifacts: libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
76+
artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a
8677

8778
build-arm64-linux:
8879
env:
@@ -100,11 +91,6 @@ jobs:
10091
submodules: recursive
10192
fetch-depth: 0
10293

103-
- name: Read version
104-
id: read-version
105-
run: |
106-
echo "version=`cat V8_REVISION`" >> "$GITHUB_OUTPUT"
107-
10894
- run: |
10995
sudo apt-get update
11096
sudo apt-get install -yq libglib2.0-dev lld
@@ -116,13 +102,13 @@ jobs:
116102
117103
- run: zig build get-v8
118104
- run: zig build -Doptimize=ReleaseSafe build-v8
119-
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
105+
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a
120106

121107
- name: Upload the build
122108
uses: ncipollo/release-action@v1
123109
with:
124110
allowUpdates: true
125-
artifacts: libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
111+
artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a
126112

127113
build-x86_64-macos:
128114
env:
@@ -144,17 +130,12 @@ jobs:
144130
submodules: recursive
145131
fetch-depth: 0
146132

147-
- name: Read version
148-
id: read-version
149-
run: |
150-
echo "version=`cat V8_REVISION`" >> "$GITHUB_OUTPUT"
151-
152133
- run: zig build get-v8
153134
- run: zig build -Doptimize=ReleaseSafe build-v8
154-
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
135+
- run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a
155136

156137
- name: Upload the build
157138
uses: ncipollo/release-action@v1
158139
with:
159140
allowUpdates: true
160-
artifacts: libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
141+
artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a

0 commit comments

Comments
 (0)