Merge pull request #130 from lightpanda-io/direct_v8

Direct v8

Author: karlseguin

src/binding.cpp

@@ -290,6 +290,10 @@ const v8::Context* v8__Isolate__GetCurrentContext(v8::Isolate* isolate) {
     return local_to_ptr(isolate->GetCurrentContext());
 }
 
+int v8__Isolate__ContextDisposedNotification(v8::Isolate* isolate) {
+    return isolate->ContextDisposedNotification();
+}
+
 size_t v8__Isolate__CreateParams__SIZEOF() {
     return sizeof(v8::Isolate::CreateParams);
 }
@@ -1575,6 +1579,51 @@ void v8__Persistent__SetWeakFinalizer(
     self->SetWeak(finalizer_ctx, finalizer_cb, type);
 }
 
+// Global
+
+void v8__Global__New(
+        v8::Isolate* isolate,
+        const v8::Data& data,
+        v8::Global<v8::Data>* out) {
+    new (out) v8::Global<v8::Data>(isolate, ptr_to_local(&data));
+}
+
+void v8__Global__Reset(v8::Global<v8::Data>* self) {
+    self->Reset();
+}
+
+void v8__Global__SetWeak(v8::Global<v8::Data>* self) {
+    self->SetWeak();
+}
+
+void v8__Global__SetWeakFinalizer(
+        v8::Global<v8::Data>* self,
+        void* finalizer_ctx,
+        v8::WeakCallbackInfo<void>::Callback finalizer_cb,
+        v8::WeakCallbackType type) {
+    self->SetWeak(finalizer_ctx, finalizer_cb, type);
+}
+const v8::Data* v8__Global__Get(
+        const v8::Global<v8::Data>* self,
+        v8::Isolate* isolate) {
+    return local_to_ptr(self->Get(isolate));
+}
+
+// Eternal
+
+void v8__Eternal__New(
+        v8::Isolate* isolate,
+        const v8::Data& data,
+        v8::Eternal<v8::Data>* out) {
+    new (out) v8::Eternal<v8::Data>(isolate, ptr_to_local(&data));
+}
+
+const v8::Data* v8__Eternal__Get(
+        const v8::Eternal<v8::Data>* self,
+        v8::Isolate* isolate) {
+    return local_to_ptr(self->Get(isolate));
+}
+
 // WeakCallbackInfo
 
 v8::Isolate* v8__WeakCallbackInfo__GetIsolate(
@@ -2327,4 +2376,8 @@ bool v8__StartupData__IsValid(v8::StartupData self) {
     return self.IsValid();
 }
 
+void v8__StartupData__DELETE(const char* data) {
+    delete[] data;
+}
+
 } // extern "C"

src/binding.h

@@ -10,10 +10,10 @@ typedef struct Isolate Isolate;
 typedef struct StackTrace StackTrace;
 typedef struct StackFrame StackFrame;
 typedef struct FixedArray FixedArray;
-typedef struct Module Module;
+typedef struct Data Module;
 typedef struct FunctionTemplate FunctionTemplate;
 typedef struct Message Message;
-typedef struct Context Context;
+typedef struct Data Context;
 // Internally, all Value types have a base InternalAddress struct.
 typedef uintptr_t InternalAddress;
 // Super type.
@@ -217,6 +217,7 @@ Context* v8__Isolate__GetCurrentContext(Isolate* isolate);
 const Value* v8__Isolate__ThrowException(
     Isolate* isolate,
     const Value* exception);
+int v8__Isolate__ContextDisposedNotification(Isolate* isolate);
 void v8__Isolate__SetHostImportModuleDynamicallyCallback(
     Isolate* isolate,
     HostImportModuleDynamicallyCallback callback);
@@ -411,7 +412,6 @@ bool v8__StackFrame__IsWasm(const StackFrame* self);
 bool v8__StackFrame__IsUserJavaScript(const StackFrame* self);
 
 // Context
-typedef struct Context Context;
 typedef struct ObjectTemplate ObjectTemplate;
 Context* v8__Context__New(Isolate* isolate, const ObjectTemplate* global_tmpl, const Value* global_obj);
 Context* v8__Context__FromSnapshot(Isolate*, size_t);
@@ -863,6 +863,39 @@ void v8__Persistent__SetWeakFinalizer(
     WeakCallback finalizer_cb,
     WeakCallbackType type);
 
+// Global
+typedef struct Global {
+    uintptr_t data_ptr;
+} Global;
+void v8__Global__New(
+    Isolate* isolate,
+    const Data* data,
+    Global* out);
+void v8__Global__Reset(
+    Global* self);
+void v8__Global__SetWeak(
+    Global* self);
+void v8__Global__SetWeakFinalizer(
+    Global* self,
+    void* finalizer_ctx,
+    WeakCallback finalizer_cb,
+    WeakCallbackType type);
+const Data* v8__Global__Get(
+    const Global* self,
+    Isolate* isolate);
+
+// Eternal
+typedef struct Eternal {
+    uintptr_t data_ptr;
+} Eternal;
+void v8__Eternal__New(
+    Isolate* isolate,
+    const Data* data,
+    Eternal* out);
+const Data* v8__Eternal__Get(
+    const Eternal* self,
+    Isolate* isolate);
+
 // WeakCallbackInfo
 Isolate* v8__WeakCallbackInfo__GetIsolate(const WeakCallbackInfo* self);
 void* v8__WeakCallbackInfo__GetParameter(const WeakCallbackInfo* self);
@@ -1287,3 +1320,4 @@ size_t v8__SnapshotCreator__AddData2(SnapshotCreator*, const Context* ctx, const
 StartupData v8__SnapshotCreator__createBlob(SnapshotCreator*, FunctionCodeHandling);
 void v8__SnapshotCreator__DESTRUCT(SnapshotCreator*);
 bool v8__StartupData__IsValid(StartupData);
+void v8__StartupData__DELETE(const char* data);

src/v8.zig

@@ -2902,67 +2902,67 @@ pub const InspectorClient = struct {
     }
 };
 
-pub export fn v8_inspector__Client__IMPL__generateUniqueId(
-    _: *c.InspectorClientImpl,
-    data: *anyopaque,
-) callconv(.c) i64 {
-    const inspector = Inspector.fromData(data);
-    return inspector.rnd.random().int(i64);
-}
-
-pub export fn v8_inspector__Client__IMPL__runMessageLoopOnPause(
-    _: *c.InspectorClientImpl,
-    data: *anyopaque,
-    contextGroupId: c_int,
-) callconv(.c) void {
-    const inspector = Inspector.fromData(data);
-    inspector.channel.onRunMessageLoopOnPause(inspector.channel.ctx, @intCast(contextGroupId));
-}
-
-pub export fn v8_inspector__Client__IMPL__quitMessageLoopOnPause(
-    _: *c.InspectorClientImpl,
-    data: *anyopaque,
-) callconv(.c) void {
-    const inspector = Inspector.fromData(data);
-    inspector.channel.onQuitMessageLoopOnPause(inspector.channel.ctx);
-}
-
-pub export fn v8_inspector__Client__IMPL__runIfWaitingForDebugger(
-    _: *c.InspectorClientImpl,
-    data: *anyopaque,
-    contextGroupId: c_int,
-) callconv(.c) void {
-    _ = contextGroupId;
-    const inspector = Inspector.fromData(data);
-    _ = inspector;
-    // TODO
-}
-
-// TODO: move params to C types
-pub export fn v8_inspector__Client__IMPL__consoleAPIMessage(
-    _: *c.InspectorClientImpl,
-    data: *anyopaque,
-    contextGroupId: c_int,
-    _: c.MessageErrorLevel,
-    _: *c.StringView,
-    _: *c.StringView,
-    _: c_uint,
-    _: c_uint,
-    _: *c.StackTrace,
-) callconv(.c) void {
-    _ = contextGroupId;
-    const inspector = Inspector.fromData(data);
-    _ = inspector;
-    // TODO
-}
-
-pub export fn v8_inspector__Client__IMPL__ensureDefaultContextInGroup(
-    _: *c.InspectorClientImpl,
-    data: *anyopaque,
-) callconv(.c) ?*const C_Context {
-    const inspector = Inspector.fromData(data);
-    return inspector.ctx_handle;
-}
+// pub export fn v8_inspector__Client__IMPL__generateUniqueId(
+//     _: *c.InspectorClientImpl,
+//     data: *anyopaque,
+// ) callconv(.c) i64 {
+//     const inspector = Inspector.fromData(data);
+//     return inspector.rnd.random().int(i64);
+// }
+
+// pub export fn v8_inspector__Client__IMPL__runMessageLoopOnPause(
+//     _: *c.InspectorClientImpl,
+//     data: *anyopaque,
+//     contextGroupId: c_int,
+// ) callconv(.c) void {
+//     const inspector = Inspector.fromData(data);
+//     inspector.channel.onRunMessageLoopOnPause(inspector.channel.ctx, @intCast(contextGroupId));
+// }
+
+// pub export fn v8_inspector__Client__IMPL__quitMessageLoopOnPause(
+//     _: *c.InspectorClientImpl,
+//     data: *anyopaque,
+// ) callconv(.c) void {
+//     const inspector = Inspector.fromData(data);
+//     inspector.channel.onQuitMessageLoopOnPause(inspector.channel.ctx);
+// }
+
+// pub export fn v8_inspector__Client__IMPL__runIfWaitingForDebugger(
+//     _: *c.InspectorClientImpl,
+//     data: *anyopaque,
+//     contextGroupId: c_int,
+// ) callconv(.c) void {
+//     _ = contextGroupId;
+//     const inspector = Inspector.fromData(data);
+//     _ = inspector;
+//     // TODO
+// }
+
+// // TODO: move params to C types
+// pub export fn v8_inspector__Client__IMPL__consoleAPIMessage(
+//     _: *c.InspectorClientImpl,
+//     data: *anyopaque,
+//     contextGroupId: c_int,
+//     _: c.MessageErrorLevel,
+//     _: *c.StringView,
+//     _: *c.StringView,
+//     _: c_uint,
+//     _: c_uint,
+//     _: *c.StackTrace,
+// ) callconv(.c) void {
+//     _ = contextGroupId;
+//     const inspector = Inspector.fromData(data);
+//     _ = inspector;
+//     // TODO
+// }
+
+// pub export fn v8_inspector__Client__IMPL__ensureDefaultContextInGroup(
+//     _: *c.InspectorClientImpl,
+//     data: *anyopaque,
+// ) callconv(.c) ?*const C_Context {
+//     const inspector = Inspector.fromData(data);
+//     return inspector.ctx_handle;
+// }
 
 comptime {
     if (@import("default_exports").inspector_subtype) {
@@ -3023,35 +3023,35 @@ pub const InspectorChannel = struct {
     }
 };
 
-pub export fn v8_inspector__Channel__IMPL__sendResponse(
-    _: *c.InspectorChannelImpl,
-    data: *anyopaque,
-    call_id: c_int,
-    msg: [*c]u8,
-    length: usize,
-) callconv(.c) void {
-    const inspector = Inspector.fromData(data);
-    inspector.channel.resp(@as(u32, @intCast(call_id)), msg[0..length]);
-}
-
-pub export fn v8_inspector__Channel__IMPL__sendNotification(
-    _: *c.InspectorChannelImpl,
-    data: *anyopaque,
-    msg: [*c]u8,
-    length: usize,
-) callconv(.c) void {
-    const inspector = Inspector.fromData(data);
-    inspector.channel.notif(msg[0..length]);
-}
-
-pub export fn v8_inspector__Channel__IMPL__flushProtocolNotifications(
-    _: *c.InspectorChannelImpl,
-    data: *anyopaque,
-) callconv(.c) void {
-    const inspector = Inspector.fromData(data);
-    _ = inspector;
-    // TODO
-}
+// pub export fn v8_inspector__Channel__IMPL__sendResponse(
+//     _: *c.InspectorChannelImpl,
+//     data: *anyopaque,
+//     call_id: c_int,
+//     msg: [*c]u8,
+//     length: usize,
+// ) callconv(.c) void {
+//     const inspector = Inspector.fromData(data);
+//     inspector.channel.resp(@as(u32, @intCast(call_id)), msg[0..length]);
+// }
+
+// pub export fn v8_inspector__Channel__IMPL__sendNotification(
+//     _: *c.InspectorChannelImpl,
+//     data: *anyopaque,
+//     msg: [*c]u8,
+//     length: usize,
+// ) callconv(.c) void {
+//     const inspector = Inspector.fromData(data);
+//     inspector.channel.notif(msg[0..length]);
+// }
+
+// pub export fn v8_inspector__Channel__IMPL__flushProtocolNotifications(
+//     _: *c.InspectorChannelImpl,
+//     data: *anyopaque,
+// ) callconv(.c) void {
+//     const inspector = Inspector.fromData(data);
+//     _ = inspector;
+//     // TODO
+// }
 
 // InspectorSession