Skip to content

Commit 78f82e9

Browse files
committed
Disable llvm_atomic (fails to build on some linux)
1 parent bad207b commit 78f82e9

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

build-tools/.gn

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,4 +99,7 @@ default_args = {
9999

100100
# requires rust toolchain
101101
v8_enable_temporal_support = false
102+
103+
# build fails on some linux systems without this
104+
use_llvm_libatomic = false
102105
}

build-tools/get_v8.sh

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,27 @@ source utils.sh
77

88
REVISION=14.0.365.4
99

10-
cloneDep() {
10+
11+
clone() {
1112
if [ -d "${2}" ]; then
1213
warn "dependency ${2} already exists, skipping"
1314
else
14-
dep_info=$(python3 deps_get.py deps.json "${1}")
15-
IFS=@ read -r dep_path dep_commit <<< "${dep_info}"
16-
1715
say "cloning dependency ${1}"
18-
git clone --depth=1 "${dep_path}" "${2}"
16+
git clone --depth=1 "${1}" "${2}"
1917
pushd "${2}"
20-
git fetch --depth=1 origin ${dep_commit}
21-
git -c advice.detachedHead=false checkout ${dep_commit}
22-
git branch -D \@{-1} || true
18+
git fetch --depth=1 origin $3
19+
git -c advice.detachedHead=false checkout $3
20+
git branch -D \@{-1} || true # if you want to tidy up the fetched branch
2321
popd
2422
fi
2523
}
2624

25+
cloneDep() {
26+
dep_info=$(python3 deps_get.py deps.json "${1}")
27+
IFS=@ read -r dep_path dep_commit <<< "${dep_info}"
28+
clone $dep_path $2 $dep_commit
29+
}
30+
2731
if [ -d "src" ]; then
2832
warn "v8/src/ already exists, only cloning dependencies"
2933
else

0 commit comments

Comments
 (0)