Add CompilationDetails sizeof test, remove unnecessary casts

Author: karlseguin

src/binding.cpp

@@ -580,6 +580,9 @@ const v8::Module* v8__ScriptCompiler__CompileModule(
     return maybe_local_to_ptr(maybe_local);
 }
 
+size_t v8__ScriptCompiler__CompilationDetails__SIZEOF() {
+    return sizeof(v8::ScriptCompiler::CompilationDetails);
+}
 // Module
 
 v8::Module::Status v8__Module__GetStatus(const v8::Module& self) {
@@ -1714,8 +1717,8 @@ static inline std::string fromStringView(v8::Isolate* isolate, const v8_inspecto
   int length = static_cast<int>(stringView.length());
   v8::Local<v8::String> message = (
         stringView.is8Bit()
-          ? v8::String::NewFromOneByte(isolate, reinterpret_cast<const uint8_t*>(stringView.characters8()), v8::NewStringType::kNormal, length)
-          : v8::String::NewFromTwoByte(isolate, reinterpret_cast<const uint16_t*>(stringView.characters16()), v8::NewStringType::kNormal, length)
+          ? v8::String::NewFromOneByte(isolate, stringView.characters8(), v8::NewStringType::kNormal, length)
+          : v8::String::NewFromTwoByte(isolate, stringView.characters16(), v8::NewStringType::kNormal, length)
       ).ToLocalChecked();
   v8::String::Utf8Value result(isolate, message);
   return *result;

src/binding.h

@@ -953,6 +953,7 @@ void v8__ScriptOrigin__CONSTRUCT2(
     const Data* host_defined_options
 );
 
+usize v8__ScriptCompiler__CompilationDetails__SIZEOF();
 typedef struct CompilationDetails {
     //  this is an enum, but should get padded to an int64_t
     int64_t in_memory_cache_result;

src/v8.zig

@@ -1043,6 +1043,12 @@ pub const ObjectTemplate = struct {
         c.v8__ObjectTemplate__SetNamedHandler(self.handle, &conf);
     }
 
+    // JS has two types of properties: data and accessors. The data property, what
+    // v8 calls a NativeData property is like a field, obj.x. An access properties
+    // is one or both of a get and set function.
+    // They seem to mostly differ in subtle ways relating to meta programming
+    // and how they're resolve in the prototype chain.
+    // https://tc39.es/ecma262/multipage/ecmascript-data-types-and-values.html#sec-object-type
     pub fn setNativeGetter(self: Self, key: Name, getter: c.AccessorNameGetterCallback) void {
         c.v8__ObjectTemplate__SetNativeDataProperty__DEFAULT(self.handle, key.handle, getter);
     }
@@ -2656,6 +2662,7 @@ test "Internals." {
     try eq(c.v8__PromiseRejectMessage__SIZEOF(), @sizeOf(c.PromiseRejectMessage));
     try eq(c.v8__ScriptCompiler__Source__SIZEOF(), @sizeOf(c.ScriptCompilerSource));
     try eq(c.v8__ScriptCompiler__CachedData__SIZEOF(), @sizeOf(c.ScriptCompilerCachedData));
+    try eq(c.v8__ScriptCompiler__CompilationDetails__SIZEOF(), @sizeOf(c.CompilationDetails));
     try eq(c.v8__HeapStatistics__SIZEOF(), @sizeOf(c.HeapStatistics));
 }