Merge pull request #33 from lightpanda-io/inspector-cli-ensure-default-ctx

inspector: implement ensure default context

Author: francisbouvier

src/binding.cpp

@@ -1681,6 +1681,8 @@ void v8_inspector__Client__IMPL__consoleAPIMessage(
     const v8_inspector::StringView &message,
     const v8_inspector::StringView &url, unsigned lineNumber,
     unsigned columnNumber, v8_inspector::V8StackTrace *stackTrace);
+const v8::Context* v8_inspector__Client__IMPL__ensureDefaultContextInGroup(
+    v8_inspector__Client__IMPL* self, void* data, int contextGroupId);
 
 // c++ implementation (just wrappers around the c/zig functions)
 } // extern "C"
@@ -1705,6 +1707,9 @@ void v8_inspector__Client__IMPL::consoleAPIMessage(
       this, this->data, contextGroupId, level, message, url, lineNumber,
       columnNumber, stackTrace);
 }
+v8::Local<v8::Context> v8_inspector__Client__IMPL::ensureDefaultContextInGroup(int contextGroupId) {
+  return ptr_to_local(v8_inspector__Client__IMPL__ensureDefaultContextInGroup(this, this->data, contextGroupId));
+}
 
 extern "C" {
 

src/binding.h

@@ -946,6 +946,8 @@ void v8_inspector__Client__IMPL__consoleAPIMessage(
     InspectorClientImpl *self, int contextGroupId, MessageErrorLevel level,
     StringView *message, StringView *url, unsigned lineNumber,
     unsigned columnNumber, StackTrace *StackTrace);
+const Context* v8_inspector__Client__IMPL__ensureDefaultContextInGroup(
+    InspectorClientImpl* self, void* data, int contextGroupId);
 
 // InspectorSession
 

src/inspector.h

@@ -38,6 +38,7 @@ class v8_inspector__Client__IMPL
                          const v8_inspector::StringView& url,
                          unsigned lineNumber, unsigned columnNumber,
                          v8_inspector::V8StackTrace* stackTrace) override;
+  v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override;
 };
 
 #endif // V8INSPECTORIMPL_H

src/v8.zig

@@ -2300,6 +2300,10 @@ pub const Inspector = struct {
 
     rnd: RndGen = RndGen.init(0),
 
+    // The default JS context handle.
+    // Set when a context is created.
+    ctx_handle: ?*const C_Context = null,
+
     const RndGen = std.rand.DefaultPrng;
 
     const contextGroupId = 1;
@@ -2345,12 +2349,13 @@ pub const Inspector = struct {
     }
 
     pub fn contextCreated(
-        self: Inspector,
+        self: *Inspector,
         ctx: Context,
         name: []const u8,
         origin: []const u8,
         auxData: ?[]const u8,
     ) void {
+        std.log.debug("Inspector contextCreated called", .{});
         var auxData_ptr: [*c]const u8 = undefined;
         var auxData_len: usize = undefined;
         if (auxData) |data| {
@@ -2371,6 +2376,7 @@ pub const Inspector = struct {
             contextGroupId,
             ctx.handle,
         );
+        self.ctx_handle = ctx.handle;
     }
 };
 
@@ -2453,6 +2459,15 @@ pub export fn v8_inspector__Client__IMPL__consoleAPIMessage(
     // TODO
 }
 
+pub export fn v8_inspector__Client__IMPL__ensureDefaultContextInGroup(
+    _: *c.InspectorClientImpl,
+    data: *anyopaque,
+) callconv(.C) ?*const C_Context {
+    std.log.debug("InspectorClient ensureDefaultContextInGroup called", .{});
+    const inspector = Inspector.fromData(data);
+    return inspector.ctx_handle;
+}
+
 // InspectorChannel
 
 pub const InspectorChannel = struct {