Merge pull request #67 from lightpanda-io/fix_build

Fix build

Author: karlseguin

.github/workflows/build-release.yml

@@ -76,7 +76,7 @@ jobs:
 
       - run: zig build get-v8
       - run: zig build -Doptimize=ReleaseSafe
-      - run: mv mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
+      - run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
 
       - name: Upload the build
         uses: ncipollo/release-action@v1
@@ -107,11 +107,16 @@ jobs:
 
       - run: |
           sudo apt-get update
-          sudo apt-get install -yq libglib2.0-dev
+          sudo apt-get install -yq libglib2.0-dev lld
+          wget https://apt.llvm.org/llvm.sh
+          chmod +x llvm.sh
+          sudo ./llvm.sh 21
+          sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins-aarch64.a /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins.a && \
+          sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/ /usr/lib/llvm-21/lib/clang/21/lib/aarch64-unknown-linux-gnu
 
       - run: zig build get-v8
       - run: zig build -Doptimize=ReleaseSafe
-      - run: mv mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
+      - run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
 
       - name: Upload the build
         uses: ncipollo/release-action@v1
@@ -146,7 +151,7 @@ jobs:
 
       - run: zig build get-v8
       - run: zig build -Doptimize=ReleaseSafe
-      - run: mv mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
+      - run: mv v8/out/release/obj/zig/libc_v8.a libc_v8_${{steps.read-version.outputs.version}}_${{ env.OS }}_${{ env.ARCH }}.a
 
       - name: Upload the build
         uses: ncipollo/release-action@v1

build-tools/build_v8.sh

@@ -6,22 +6,11 @@ set -o errtrace # inherits trap on ERR in function and subshell
 source utils.sh
 
 SRC_ROOT=${1:-"../src"}
+MODE=${2:-"debug"}
 
 cp ${SRC_ROOT}/binding.cpp src/
 cp ${SRC_ROOT}/inspector.h src/
 
-ARCH=$(uname -m);
-case "$ARCH" in
-  x86_64) ARCH="x64" ;;
-esac
-
-case "$OSTYPE" in
-  darwin*)  OS="mac" ;;
-  linux*)   OS="linux" ;;
-  *)        fail "unsupported platform: ${OSTYPE}"
-esac
-
-MODE=${2:-"debug"}
 OUT=out/${MODE}
 
 if [[ ${MODE} == "release" ]]; then
@@ -35,18 +24,28 @@ fi
 mkdir -p src/zig
 cp BUILD.gn src/zig/
 
+EXTRA_ARGS=""
+if [ "${OS}" = "linux" ] && [ "${ARCH}" == "arm64" ]; then
+  EXTRA_ARGS="clang_base_path=\"/usr/lib/llvm-21\" clang_use_chrome_plugins=false treat_warnings_as_errors=false"
+fi
+
+TARGET_ARCH=${ARCH}
+if [ "${ARCH}" = "amd64" ]; then
+  TARGET_ARCH="x64"
+fi
+
 tools/gn \
   --root=src \
   --root-target=//zig \
   --dotfile=.gn  \
   gen ${OUT} \
   --args="
     target_os=\"${OS}\"
-    target_cpu=\"${ARCH}\"
-    host_cpu=\"${ARCH}\"
+    target_cpu=\"${TARGET_ARCH}\"
+    host_cpu=\"${TARGET_ARCH}\"
     is_debug=${IS_DEBUG}
     symbol_level=${SYMBOL_LEVEL}
-    is_official_build=false
+    is_official_build=false ${EXTRA_ARGS}
   "
 
 tools/ninja -C ${OUT} "c_v8"

build-tools/get_tools.sh

@@ -7,18 +7,18 @@ source utils.sh
 
 mkdir -p tools/
 
-case "$OSTYPE" in
-  darwin*)  OS="mac" ;;
-  linux*)   OS="linux" ;;
-  *)        fail "unsupported platform: ${OSTYPE}"
-esac
-
 if [ ! -f tools/gn ]; then
-  download "https://chrome-infra-packages.appspot.com/dl/gn/gn/${OS}-amd64/+/latest" tools/gn.zip
+  GN_ARCHIVE="${OS}-${ARCH}"
+  download "https://chrome-infra-packages.appspot.com/dl/gn/gn/${GN_ARCHIVE}/+/latest" tools/gn.zip
   unzip -o tools/gn.zip -d tools
 fi
 
 if [ ! -f tools/ninja ]; then
-  download "https://github.com/ninja-build/ninja/releases/download/v1.12.1/ninja-${OS}.zip" tools/ninja.zip
+  NINJA_ARCHIVE="ninja-${OS}.zip"
+  if [ "${OS}" = "linux" ] && [ "${ARCH}" == "arm64" ]; then
+    NINJA_ARCHIVE="ninja-linux-aarch64.zip"
+  fi
+
+  download "https://github.com/ninja-build/ninja/releases/download/v1.12.1/${NINJA_ARCHIVE}" tools/ninja.zip
   unzip -o tools/ninja.zip  -d tools
 fi

build-tools/get_v8.sh

@@ -2,6 +2,7 @@
 set -o errexit #  exit on errors
 set -o nounset # exit on use of uninitialized variable
 set -o errtrace # inherits trap on ERR in function and subshell
+
 source utils.sh
 
 REVISION=13.6.233.8

build-tools/utils.sh

@@ -15,3 +15,16 @@ download() {
   say "downloading ${1} into ${2}"
   curl -L ${1} -o ${2}
 }
+
+case $(uname -m) in
+  arm*)     ARCH="arm64" ;;
+  aarch64)  ARCH="arm64" ;;
+  x86_64)   ARCH="amd64" ;;
+  *)      fail "unsupported architecture: $(uname -m)"
+esac
+
+case "$OSTYPE" in
+  darwin*)  OS="mac" ;;
+  linux*)   OS="linux" ;;
+  *)        fail "unsupported platform: ${OSTYPE}"
+esac