From ef04fc3a841105d6a082f975ca80eccae21d8fce Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Sat, 28 Jun 2025 13:16:59 -0700 Subject: [PATCH 1/2] ci: use ubuntu 22.04 to build arm64/linux --- .github/workflows/build-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index e0c83da..808ff56 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -80,7 +80,7 @@ jobs: OS: linux ARCH: aarch64 - runs-on: ubuntu-24.04-arm + runs-on: ubuntu-22.04-arm steps: - uses: mlugg/setup-zig@v2 with: From 2caa4717c62342351a67d20b29c1b60bc858739d Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Sat, 28 Jun 2025 13:19:34 -0700 Subject: [PATCH 2/2] wip for tests --- .github/workflows/build-release.yml | 97 +---------------------------- 1 file changed, 2 insertions(+), 95 deletions(-) diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index 808ff56..c9e0da0 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -4,6 +4,8 @@ on: push: tags: - "**" + pull_request: + types: [opened, synchronize, reopened, ready_for_review] # Allows you to run this workflow manually from the Actions tab workflow_dispatch: @@ -15,65 +17,6 @@ env: V8_REVISION: 13.6.233.8 jobs: - build-x86_64-linux: - env: - OS: linux - ARCH: x86_64 - - runs-on: ubuntu-22.04 - steps: - - uses: mlugg/setup-zig@v2 - with: - version: ${{ env.ZIG_VERSION }} - - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - run: | - sudo apt-get update - sudo apt-get install -yq libglib2.0-dev - - - run: zig build get-v8 - - run: zig build -Doptimize=ReleaseSafe build-v8 - - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - build-aarch64-macos: - env: - OS: macos - ARCH: aarch64 - - runs-on: macos-latest - steps: - - uses: mlugg/setup-zig@v2 - with: - version: ${{ env.ZIG_VERSION }} - - - uses: actions/setup-python@v5 - with: - python-version: '3.11' - - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - run: zig build get-v8 - - run: zig build -Doptimize=ReleaseSafe build-v8 - - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a build-arm64-linux: env: @@ -103,39 +46,3 @@ jobs: - run: zig build get-v8 - run: zig build -Doptimize=ReleaseSafe build-v8 - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - build-x86_64-macos: - env: - OS: macos - ARCH: x86_64 - - runs-on: macos-13 - steps: - - uses: mlugg/setup-zig@v2 - with: - version: ${{ env.ZIG_VERSION }} - - - uses: actions/setup-python@v5 - with: - python-version: '3.11' - - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - run: zig build get-v8 - - run: zig build -Doptimize=ReleaseSafe build-v8 - - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a