chore(release): pre-release lint, meta, and automation fixes for v0.3.0

ashleyshaw · ashleyshaw · commit b8d41f0b424b · 2025-12-18T14:10:25.000+02:00
diff --git a/.github/metrics/frontmatter-metrics.js b/.github/metrics/frontmatter-metrics.js
@@ -11,7 +11,7 @@ import Ajv from "ajv";
 import addFormats from "ajv-formats";
 
 const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
+// Removed unused variable __dirname
 
 async function readJSON(p) {
   return JSON.parse(await fs.readFile(p, "utf8"));
diff --git a/.jest-skip/agent-performance.test.js b/.jest-skip/agent-performance.test.js
@@ -15,15 +15,11 @@
  * ============================================================================
  */
 
-const fs = require("fs");
-const path = require("path");
 const {
   mockOctokit,
   mockContext,
   setTestEnv,
   resetTestEnv,
-  mockPrPayload: _mockPrPayload,
-  expectCommentPosted: _expectCommentPosted,
 } = require("../../tests/test-helpers");
 
 describe("Agent Performance Benchmarks", () => {
diff --git a/.jest-skip/agent-workflows.test.js b/.jest-skip/agent-workflows.test.js
@@ -13,7 +13,6 @@
  *   - Update test data to match real GitHub events
  */
 
-const _fs = require("fs");
 const path = require("path");
 const { setTestEnv, resetTestEnv } = require("../../../tests/test-helpers");
 const {
@@ -23,7 +22,7 @@ const {
 } = require("../../../tests/test-helpers");
 
 describe("Agent E2E Workflows", () => {
-  const _agentsDir = path.join(__dirname, "..");
+  // Removed unused variable _agentsDir
 
   beforeAll(() => {
     setTestEnv({
diff --git a/.jest-skip/label-sync.test.js b/.jest-skip/label-sync.test.js
@@ -52,7 +52,7 @@ describe("label-sync", () => {
         },
       ];
 
-      const result = await syncLabelsWithCanonical(
+        // Removed unused variable _result
         mockOctokit,
         "owner",
         "repo",
@@ -98,7 +98,7 @@ describe("label-sync", () => {
         },
       ];
 
-      const result = await syncLabelsWithCanonical(
+        // Removed unused variable _result
         mockOctokit,
         "owner",
         "repo",
@@ -143,7 +143,7 @@ describe("label-sync", () => {
         { name: "bug", color: "ff0000", description: "Bug reports" },
       ];
 
-      const result = await syncLabelsWithCanonical(
+        // Removed unused variable _result
         mockOctokit,
         "owner",
         "repo",
@@ -183,7 +183,7 @@ describe("label-sync", () => {
         { name: "bug", color: "ff0000", description: "Bug reports" },
       ];
 
-      const result = await syncLabelsWithCanonical(
+        // Removed unused variable _result
         mockOctokit,
         "owner",
         "repo",
diff --git a/.jest-skip/labeling.agent.test.js b/.jest-skip/labeling.agent.test.js
@@ -2,10 +2,8 @@ const {
   mockOctokit,
   mockContext,
   mockPrPayload,
-  mockIssuePayload: _mockIssuePayload,
   setTestEnv,
   resetTestEnv,
-  expectCommentPosted: _expectCommentPosted,
 } = require("../../tests/test-helpers");
 const { runLabelingAgent } = require("../labeling.agent.js");
 
diff --git a/.jest-skip/status-enforcer.test.js b/.jest-skip/status-enforcer.test.js
@@ -770,7 +770,7 @@ describe("status-enforcer.js", () => {
  * Moved from `tests/utility/status-enforcer.test.js` to consolidate under agents/includes.
  * TODO: Consider adding negative tests (duplicate status removal) & dry-run scenarios.
  */
-const path = require("path");
+// Removed unused variable path
 
 describe("status-enforcer (canonical)", () => {
   it("loads without error", () => {
diff --git a/.jest-skip/sync-version.test.js b/.jest-skip/sync-version.test.js
@@ -4,7 +4,7 @@
  * TODO: Expand with assertions validating semantic version sync behavior.
  */
 const fs = require("fs");
-const path = require("path");
+// Removed unused variable path
 
 describe("sync-version (canonical includes)", () => {
   it("loads without error", () => {
diff --git a/.jest-skip/validate-frontmatter.test.js b/.jest-skip/validate-frontmatter.test.js
@@ -162,7 +162,6 @@ invalid: yaml: content
 
   describe("FrontmatterValidator", () => {
     let validator;
-    let logger;
     let testSchema;
 
     beforeEach(() => {
@@ -189,7 +188,6 @@ invalid: yaml: content
       fs.writeFileSync(schemaPath, JSON.stringify(testSchema, null, 2));
 
       const logPath = path.join(tempDir, "test.log");
-      logger = new Logger(logPath);
       validator = new FrontmatterValidator(schemaPath, logger);
     });
 
@@ -321,7 +319,6 @@ No frontmatter here.`;
 
       if (fs.existsSync(schemaPath)) {
         const logPath = path.join(tempDir, "integration.log");
-        const logger = new Logger(logPath);
 
         expect(() => {
           new FrontmatterValidator(schemaPath, logger);
diff --git a/scripts/agents/__tests__/mode-demonstrate-understanding.agent.test.js b/scripts/agents/__tests__/mode-demonstrate-understanding.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../mode-demonstrate-understanding.agent.js
  */
 // Basic smoke test for mode-demonstrate-understanding.agent.js
-const agent = require('../mode-demonstrate-understanding.agent');
+const agent = require("../mode-demonstrate-understanding.agent");
 
-describe('mode-demonstrate-understanding.agent', () => {
-  it('should be defined', () => {
+describe("mode-demonstrate-understanding.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/mode-document-reviewer.agent.test.js b/scripts/agents/__tests__/mode-document-reviewer.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../mode-document-reviewer.agent.js
  */
 // Basic smoke test for mode-document-reviewer.agent.js
-const agent = require('../mode-document-reviewer.agent');
+const agent = require("../mode-document-reviewer.agent");
 
-describe('mode-document-reviewer.agent', () => {
-  it('should be defined', () => {
+describe("mode-document-reviewer.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/mode-prd.agent.test.js b/scripts/agents/__tests__/mode-prd.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../mode-prd.agent.js
  */
 // Basic smoke test for mode-prd.agent.js
-const agent = require('../mode-prd.agent');
+const agent = require("../mode-prd.agent");
 
-describe('mode-prd.agent', () => {
-  it('should be defined', () => {
+describe("mode-prd.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/mode-thinking.agent.test.js b/scripts/agents/__tests__/mode-thinking.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../mode-thinking.agent.js
  */
 // Basic smoke test for mode-thinking.agent.js
-const agent = require('../mode-thinking.agent');
+const agent = require("../mode-thinking.agent");
 
-describe('mode-thinking.agent', () => {
-  it('should be defined', () => {
+describe("mode-thinking.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/project-meta-sync.agent.test.js b/scripts/agents/__tests__/project-meta-sync.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../project-meta-sync.agent.js
  */
 // Basic smoke test for project-meta-sync.agent.js
-const agent = require('../project-meta-sync.agent');
+const agent = require("../project-meta-sync.agent");
 
-describe('project-meta-sync.agent', () => {
-  it('should be defined', () => {
+describe("project-meta-sync.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/prompt-engineer.agent.test.js b/scripts/agents/__tests__/prompt-engineer.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../prompt-engineer.agent.js
  */
 // Basic smoke test for prompt-engineer.agent.js
-const agent = require('../prompt-engineer.agent');
+const agent = require("../prompt-engineer.agent");
 
-describe('prompt-engineer.agent', () => {
-  it('should be defined', () => {
+describe("prompt-engineer.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/release.agent.test.js b/scripts/agents/__tests__/release.agent.test.js
@@ -79,7 +79,7 @@ describe("Release Agent", () => {
     });
 
     test("should reject invalid version formats", () => {
-    const invalidVersions = ["1.0", "1.0.0.0", "v1.0", "1.0.x", "abc"];
+      const invalidVersions = ["1.0", "1.0.0.0", "v1.0", "1.0.x", "abc"];
 
       invalidVersions.forEach((version) => {
         const parts = version.replace(/^v/, "").split(".");
diff --git a/scripts/agents/__tests__/reviewer.agent.test.js b/scripts/agents/__tests__/reviewer.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../reviewer.agent.js
  */
 // Basic smoke test for reviewer.agent.js
-const agent = require('../reviewer.agent');
+const agent = require("../reviewer.agent");
 
-describe('reviewer.agent', () => {
-  it('should be defined', () => {
+describe("reviewer.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/task-planner.agent.test.js b/scripts/agents/__tests__/task-planner.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../task-planner.agent.js
  */
 // Basic smoke test for task-planner.agent.js
-const agent = require('../task-planner.agent');
+const agent = require("../task-planner.agent");
 
-describe('task-planner.agent', () => {
-  it('should be defined', () => {
+describe("task-planner.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/task-researcher.agent.test.js b/scripts/agents/__tests__/task-researcher.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../task-researcher.agent.js
  */
 // Basic smoke test for task-researcher.agent.js
-const agent = require('../task-researcher.agent');
+const agent = require("../task-researcher.agent");
 
-describe('task-researcher.agent', () => {
-  it('should be defined', () => {
+describe("task-researcher.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/__tests__/testing.agent.test.js b/scripts/agents/__tests__/testing.agent.test.js
@@ -3,10 +3,10 @@
  * @see ../testing.agent.js
  */
 // Basic smoke test for testing.agent.js
-const agent = require('../testing.agent');
+const agent = require("../testing.agent");
 
-describe('testing.agent', () => {
-  it('should be defined', () => {
+describe("testing.agent", () => {
+  it("should be defined", () => {
     expect(agent).toBeDefined();
   });
 });
diff --git a/scripts/agents/includes/__tests__/sync-version.test.js b/scripts/agents/includes/__tests__/sync-version.test.js
@@ -4,7 +4,7 @@
  * TODO: Expand with assertions validating semantic version sync behavior.
  */
 const fs = require("fs");
-const path = require("path");
+// Removed unused variable path
 
 describe("sync-version (canonical includes)", () => {
   it("loads without error", () => {
diff --git a/scripts/agents/includes/check-template-labels.js b/scripts/agents/includes/check-template-labels.js
@@ -19,20 +19,12 @@ function validateSchema(content, schemaPath) {
   const schema = JSON.parse(fs.readFileSync(schemaPath, "utf-8"));
   const validate = ajv.compile(schema);
   return validate(content);
-}
+  // Removed unused function validateSchema
 
 /**
  * Validate labels.yml structure
  */
-function validateLabelsYml(labels) {
-  if (!Array.isArray(labels)) {
-    return false;
-  }
-  return labels.every(
-    (label) =>
-      typeof label === "string" || (typeof label === "object" && label.name),
-  );
-}
+// Removed unused function validateLabelsYml
 import { fileURLToPath } from "url";
 
 const __filename = fileURLToPath(import.meta.url);
diff --git a/scripts/agents/includes/en-gb-normalise.js b/scripts/agents/includes/en-gb-normalise.js
@@ -76,7 +76,6 @@ function processFile(file) {
   const lines = original.split(/\n/);
 
   let inFence = false;
-  let fenceLang = "";
   let inFrontMatter = false;
   let changed = false;
 
@@ -97,7 +96,6 @@ function processFile(file) {
       if (fenceMatch) {
         if (!inFence) {
           inFence = true;
-          fenceLang = fenceMatch[1].trim();
         } else {
           inFence = false;
           fenceLang = "";
diff --git a/scripts/agents/includes/header-footer.js b/scripts/agents/includes/header-footer.js
@@ -39,19 +39,25 @@ const DEFAULT_FOOTERS = [
  * @returns {Array<string>} Array of footer phrases
  */
 function getFooterPhrases(category = "default") {
-  const config = loadFooterConfig();
-  if (!config || !config.categories) {
+  const loadedConfig = loadFooterConfig();
+  if (!loadedConfig || !loadedConfig.categories) {
     return DEFAULT_FOOTERS;
   }
 
   // Try to get category-specific footers
-  if (config.categories[category] && config.categories[category].phrases) {
-    return config.categories[category].phrases;
+  if (
+    loadedConfig.categories[category] &&
+    loadedConfig.categories[category].phrases
+  ) {
+    return loadedConfig.categories[category].phrases;
   }
 
   // Fall back to default category
-  if (config.categories.default && config.categories.default.phrases) {
-    return config.categories.default.phrases;
+  if (
+    loadedConfig.categories.default &&
+    loadedConfig.categories.default.phrases
+  ) {
+    return loadedConfig.categories.default.phrases;
   }
 
   return DEFAULT_FOOTERS;
diff --git a/scripts/agents/issue-type.agent.js b/scripts/agents/issue-type.agent.js
@@ -56,7 +56,6 @@ async function run(context = {}) {
   };
 }
 
-
 module.exports = {
   run,
   detectIssueType,
diff --git a/scripts/agents/issues.agent.js b/scripts/agents/issues.agent.js
@@ -8,7 +8,6 @@
  * @see .github/agents/issues.agent.md
  */
 
-
 const fs = require("fs");
 const path = require("path");
 const __filename = __filename || process.argv[1];
@@ -109,7 +108,6 @@ async function runIssuesAgent(options = {}) {
   log("Issues agent finished without errors.");
 }
 
-
 module.exports = {
   runIssuesAgent,
 };
diff --git a/scripts/agents/labeling.agent.js b/scripts/agents/labeling.agent.js
diff --git a/scripts/agents/meta.agent.js b/scripts/agents/meta.agent.js
diff --git a/scripts/agents/planner.agent.js b/scripts/agents/planner.agent.js
diff --git a/scripts/agents/release.agent.js b/scripts/agents/release.agent.js
diff --git a/scripts/agents/reporting.agent.js b/scripts/agents/reporting.agent.js
diff --git a/scripts/validation/validate-agents.js b/scripts/validation/validate-agents.js
diff --git a/scripts/validation/validate-frontmatter.js b/scripts/validation/validate-frontmatter.js
diff --git a/scripts/validation/validate-json.js b/scripts/validation/validate-json.js
