Fix code review issues: slider dots calculation, term deletion test, query builder, gallery accessibility

Co-authored-by: ashleyshaw <[email protected]>

Author: Copilot

bin/update-version.js

@@ -40,7 +40,7 @@ const filesToUpdate = [
 	},
 	{
 		file: path.join( rootDir, '{{slug}}.php' ),
-		pattern: /define\(\s*'{{namespace\|upper}}_VERSION',\s*'[^']+'\s*\)/,
+		pattern: /define\(\s*'\{\{namespace\|upper\}\}_VERSION',\s*'[^']+'\s*\)/,
 		replacement: `define( '{{namespace|upper}}_VERSION', '${ newVersion }' )`,
 	},
 ];

src/blocks/{{slug}}-slider/view.js

@@ -104,12 +104,9 @@
 			}
 
 			dots.forEach( function ( dot, index ) {
-				const dotIndex = index * settings.slidesToScroll;
-				const isActive = currentIndex >= dotIndex &&
-					currentIndex < dotIndex + settings.slidesToScroll;
-
-				dot.classList.toggle( 'is-active', isActive || index === Math.floor( currentIndex / settings.slidesToScroll ) );
-				dot.setAttribute( 'aria-selected', dot.classList.contains( 'is-active' ) );
+				const isActive = index === Math.floor( currentIndex / settings.slidesToScroll );
+				dot.classList.toggle( 'is-active', isActive );
+				dot.setAttribute( 'aria-selected', isActive.toString() );
 			} );
 		}
 

src/components/Gallery/Gallery.js

@@ -89,6 +89,8 @@ export default function Gallery( {
 					role="dialog"
 					aria-modal="true"
 					aria-label={ __( 'Image lightbox', '{{textdomain}}' ) }
+					tabIndex={ -1 }
+					ref={ ( el ) => el && el.focus() }
 					style={ {
 						position: 'fixed',
 						inset: 0,
@@ -97,6 +99,7 @@ export default function Gallery( {
 						alignItems: 'center',
 						justifyContent: 'center',
 						zIndex: 99999,
+						outline: 'none',
 					} }
 				>
 					<img

src/components/Slider/Slider.js

@@ -198,15 +198,15 @@ export default function Slider( {
 					role="tablist"
 					aria-label={ __( 'Slider navigation', '{{textdomain}}' ) }
 				>
-					{ Array.from( { length: maxIndex + 1 } ).map( ( _, index ) => (
+					{ Array.from( { length: Math.ceil( ( totalSlides - slidesToShow ) / slidesToScroll ) + 1 } ).map( ( _, index ) => (
 						<button
 							key={ index }
 							className={ `{{namespace}}-slider__dot ${
-								index === currentIndex ? 'is-active' : ''
+								index === Math.floor( currentIndex / slidesToScroll ) ? 'is-active' : ''
 							}` }
-							onClick={ () => goToSlide( index ) }
+							onClick={ () => goToSlide( index * slidesToScroll ) }
 							role="tab"
-							aria-selected={ index === currentIndex }
+							aria-selected={ index === Math.floor( currentIndex / slidesToScroll ) }
 							aria-label={ `Go to slide ${ index + 1 }` }
 						/>
 					) ) }

src/utils/query.js

@@ -87,10 +87,8 @@ export function buildTaxQuery( taxQuery ) {
 	}
 
 	return [
-		{
-			relation: 'AND',
-			...queries,
-		},
+		{ relation: 'AND' },
+		...queries,
 	];
 }
 

tests/php/test-uninstall.php

@@ -52,9 +52,9 @@ public function test_can_delete_terms() {
 		// Delete term.
 		wp_delete_term( $term['term_id'], '{{slug}}_category' );
 
-		// Verify deletion.
+		// Verify deletion - get_term returns WP_Error or null when term doesn't exist.
 		$deleted_term = get_term( $term['term_id'], '{{slug}}_category' );
-		$this->assertNull( $deleted_term );
+		$this->assertTrue( is_wp_error( $deleted_term ) || null === $deleted_term );
 	}
 
 	/**