Skip to content

Commit b1c3e22

Browse files
committed
cmake: get rid of LUA_TARGET
Required for setting a Lua library outside.
1 parent 76387bd commit b1c3e22

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

cmake/BuildLua.cmake

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ macro(build_lua LUA_VERSION)
5959

6060
include(ExternalProject)
6161

62-
set(LUA_LIBRARIES ${PROJECT_BINARY_DIR}/lua-${LUA_VERSION}/source/liblua.a)
62+
set(LUA_LIBRARY ${PROJECT_BINARY_DIR}/lua-${LUA_VERSION}/source/liblua.a)
6363
set(LUA_EXECUTABLE ${LUA_SOURCE_DIR}/lua)
6464

6565
ExternalProject_Add(patched-lua-${LUA_VERSION}
@@ -82,12 +82,17 @@ macro(build_lua LUA_VERSION)
8282
LDFLAGS=${LDFLAGS}
8383
INSTALL_COMMAND ""
8484

85-
BUILD_BYPRODUCTS ${LUA_LIBRARIES} ${LUA_EXECUTABLE}
85+
BUILD_BYPRODUCTS ${LUA_LIBRARY} ${LUA_EXECUTABLE}
8686
)
8787

88+
add_library(bundled-liblua STATIC IMPORTED GLOBAL)
89+
set_target_properties(bundled-liblua PROPERTIES
90+
IMPORTED_LOCATION ${LUA_LIBRARY})
91+
add_dependencies(bundled-liblua patched-lua-${LUA_VERSION})
92+
93+
set(LUA_LIBRARIES bundled-liblua)
8894
set(LUA_INCLUDE_DIR ${PROJECT_BINARY_DIR}/lua-${LUA_VERSION}/source/)
8995
set(LUA_VERSION_STRING "PUC Rio Lua ${LUA_VERSION}")
90-
set(LUA_TARGET patched-lua-${LUA_VERSION})
9196

9297
unset(LUA_BINARY_DIR)
9398
unset(LUA_PATCH_PATH)

cmake/BuildLuaJIT.cmake

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ macro(build_luajit LJ_VERSION)
8383

8484
include(ExternalProject)
8585

86-
set(LUA_LIBRARIES ${LJ_SOURCE_DIR}/src/libluajit.a)
86+
set(LUA_LIBRARY ${LJ_SOURCE_DIR}/src/libluajit.a)
8787
set(LUA_EXECUTABLE ${LJ_SOURCE_DIR}/src/luajit)
8888

8989
ExternalProject_Add(patched-luajit-${LJ_VERSION}
@@ -110,13 +110,17 @@ macro(build_luajit LJ_VERSION)
110110
-C src
111111
INSTALL_COMMAND ""
112112

113-
BUILD_BYPRODUCTS ${LUA_LIBRARIES} ${LUA_EXECUTABLE}
113+
BUILD_BYPRODUCTS ${LUA_LIBRARY} ${LUA_EXECUTABLE}
114114
)
115115

116-
set(LUA_SOURCE_DIR ${LJ_SOURCE_DIR})
116+
add_library(bundled-liblua STATIC IMPORTED GLOBAL)
117+
set_target_properties(bundled-liblua PROPERTIES
118+
IMPORTED_LOCATION ${LUA_LIBRARY})
119+
add_dependencies(bundled-liblua patched-luajit-${LJ_VERSION})
120+
121+
set(LUA_LIBRARIES bundled-liblua)
117122
set(LUA_INCLUDE_DIR ${LJ_SOURCE_DIR}/src/)
118123
set(LUA_VERSION_STRING "LuaJIT ${LJ_VERSION}")
119-
set(LUA_TARGET patched-luajit-${LJ_VERSION})
120124

121125
unset(LJ_SOURCE_DIR)
122126
unset(LJ_BINARY_DIR)

libluamut/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ add_library(${LIB_LUA_MUTATE} STATIC mutate.c)
1212
target_link_libraries(${LIB_LUA_MUTATE} PRIVATE ${LUA_LIBRARIES} ${LDFLAGS})
1313
target_include_directories(${LIB_LUA_MUTATE} PRIVATE ${LUA_INCLUDE_DIR})
1414
target_compile_options(${LIB_LUA_MUTATE} PRIVATE ${CFLAGS})
15-
add_dependencies(${LIB_LUA_MUTATE} ${LUA_TARGET})
15+
add_dependencies(${LIB_LUA_MUTATE} ${LUA_LIBRARIES})
1616

1717
set(LIB_LUA_CROSSOVER lua_crossover)
1818
add_library(${LIB_LUA_CROSSOVER} STATIC crossover.c)
1919
target_link_libraries(${LIB_LUA_CROSSOVER} PRIVATE ${LUA_LIBRARIES} ${LDFLAGS})
2020
target_include_directories(${LIB_LUA_CROSSOVER} PRIVATE ${LUA_INCLUDE_DIR})
2121
target_compile_options(${LIB_LUA_CROSSOVER} PRIVATE ${CFLAGS})
22-
add_dependencies(${LIB_LUA_CROSSOVER} ${LUA_TARGET})
22+
add_dependencies(${LIB_LUA_CROSSOVER} ${LUA_LIBRARIES})
2323

2424
if (ENABLE_INTERNAL_TESTS)
2525
add_subdirectory(tests)

tests/capi/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ function(create_test)
7171
target_link_libraries(${test_name} PUBLIC fuzzer_config ${FUZZ_LIBRARIES} ${LUA_LIBRARIES} ${LDFLAGS})
7272
target_include_directories(${test_name} PRIVATE ${LUA_INCLUDE_DIR})
7373
target_compile_options(${test_name} PRIVATE -Wall -Wextra -Wpedantic -Wno-unused-parameter -g)
74-
add_dependencies(${test_name} ${LUA_TARGET})
74+
add_dependencies(${test_name} ${LUA_LIBRARIES})
7575
string(REPLACE "_test" "" test_prefix ${test_name})
7676
set(LIBFUZZER_OPTS "${LIBFUZZER_OPTS} -artifact_prefix=${test_name}_")
7777
if (USE_LUAJIT AND (${test_name} STREQUAL "lua_dump_test"))

0 commit comments

Comments
 (0)