Merge pull request #21 from liip/jms-type-name-nullable

jms type annotation is nullable

Author: dbu

.github/workflows/ci.yml

@@ -0,0 +1,41 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - 'master'
+    tags:
+      - '[0-9].[0-9]+'
+  pull_request:
+
+jobs:
+  test:
+    name: "PHPUnit"
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php-version: ['7.2', '7.3', '7.4', '8.0']
+        include:
+          - php-version: '7.2'
+            composer-flags: '--prefer-stable --prefer-lowest'
+    steps:
+      - name: Check out code into the workspace
+        uses: actions/checkout@v2
+      - name: Setup PHP ${{ matrix.php-version }}
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-version }}
+      - name: Validate composer.json
+        run: composer validate --strict --no-check-lock
+      - name: Composer cache
+        uses: actions/cache@v2
+        with:
+          path: ${{ env.HOME }}/.composer/cache
+          key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
+      - name: Install dependencies
+        run: composer update ${{ matrix.composer-flags }} --prefer-dist --no-interaction
+      - name: PHPStan
+        if: ${{ matrix.php-version == '8.0' }}
+        run: composer phpstan-all
+      - name: Run tests
+        run: composer phpunit

.travis.yml

@@ -10,6 +10,7 @@ final class ParseException extends SchemaException
     private const CLASS_ERROR = 'Class "%s" couldn\'t be parsed because of an error: %s';
     private const PROPERTY_ERROR = 'Property "%s::%s" couldn\'t be parsed because of an error: %s';
     private const PROPERTY_TYPE_ERROR = 'Property "%s::%s" has an invalid type which results in: %s';
+    private const PROPERTY_TYPE_NAME_NULL = 'Property "%s::%s" has an invalid type annotation. [Type Error] Attribute "name" of @JMS\Type may not be null.';
     private const PROPERTY_TYPE_CONFLICT = 'Property "%s::%s" has different type definitions which conflict: %s != %s';
     private const UNSUPPORTED_CLASS_ANNOTATION = 'Class "%s" has an unsupported annotation "%s"';
     private const UNSUPPORTED_PROPERTY_ANNOTATION = 'Property "%s::%s" has an unsupported annotation "%s"';
@@ -54,6 +55,11 @@ public static function propertyTypeError(string $className, string $propertyName
         );
     }
 
+    public static function propertyTypeNameNull(string $className, string $propertyName): self
+    {
+        return new self(sprintf(self::PROPERTY_TYPE_NAME_NULL, $className, $propertyName));
+    }
+
     public static function propertyTypeConflict(string $className, string $propertyName, string $typeA, string $typeB, \Exception $previousException): self
     {
         return new self(

src/Exception/ParseException.php

@@ -222,6 +222,9 @@ private function parsePropertyAnnotations(RawClassMetadata $classMetadata, Prope
         foreach ($annotations as $annotation) {
             switch (true) {
                 case $annotation instanceof Type:
+                    if (null === $annotation->name) {
+                        throw ParseException::propertyTypeNameNull((string) $classMetadata, (string) $property);
+                    }
                     try {
                         $type = $this->jmsTypeParser->parse($annotation->name);
                     } catch (InvalidTypeException $e) {

src/ModelParser/JMSParser.php

@@ -870,6 +870,7 @@ public function testVirtualPropertyWithInvalidReturnDocBlock(): void
              */
             public function getFoo()
             {
+                return fopen(__FILE__, 'rb');
             }
         };