Skip to content

Commit 16a54c2

Browse files
committed
refactor(BaseDriver): remove driver.BaseDriver from driver(wsl2) level
Signed-off-by: Ansuman Sahoo <[email protected]>
1 parent a650868 commit 16a54c2

File tree

3 files changed

+20
-59
lines changed

3 files changed

+20
-59
lines changed

pkg/wsl2/fs.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,20 @@ import (
99
"os"
1010
"path/filepath"
1111

12-
"github.com/lima-vm/lima/pkg/driver"
1312
"github.com/lima-vm/lima/pkg/fileutils"
13+
"github.com/lima-vm/lima/pkg/store"
1414
"github.com/lima-vm/lima/pkg/store/filenames"
1515
"github.com/sirupsen/logrus"
1616
)
1717

1818
// EnsureFs downloads the root fs.
19-
func EnsureFs(ctx context.Context, driver *driver.BaseDriver) error {
20-
baseDisk := filepath.Join(driver.Instance.Dir, filenames.BaseDisk)
19+
func EnsureFs(ctx context.Context, inst *store.Instance) error {
20+
baseDisk := filepath.Join(inst.Dir, filenames.BaseDisk)
2121
if _, err := os.Stat(baseDisk); errors.Is(err, os.ErrNotExist) {
2222
var ensuredBaseDisk bool
23-
errs := make([]error, len(driver.Instance.Config.Images))
24-
for i, f := range driver.Instance.Config.Images {
25-
if _, err := fileutils.DownloadFile(ctx, baseDisk, f.File, true, "the image", *driver.Instance.Config.Arch); err != nil {
23+
errs := make([]error, len(inst.Config.Images))
24+
for i, f := range inst.Config.Images {
25+
if _, err := fileutils.DownloadFile(ctx, baseDisk, f.File, true, "the image", *inst.Config.Arch); err != nil {
2626
errs[i] = err
2727
continue
2828
}

pkg/wsl2/wsl_driver_others.go

Lines changed: 0 additions & 43 deletions
This file was deleted.

pkg/wsl2/wsl_driver_windows.go

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111

1212
"github.com/Microsoft/go-winio"
1313
"github.com/Microsoft/go-winio/pkg/guid"
14-
"github.com/lima-vm/lima/pkg/driver"
1514
"github.com/lima-vm/lima/pkg/freeport"
1615
"github.com/lima-vm/lima/pkg/limayaml"
1716
"github.com/lima-vm/lima/pkg/reflectutil"
@@ -46,18 +45,23 @@ var knownYamlProperties = []string{
4645
const Enabled = true
4746

4847
type LimaWslDriver struct {
49-
*driver.BaseDriver
48+
Instance *store.Instance
49+
50+
SSHLocalPort int
51+
VSockPort int
52+
VirtioPort string
5053
}
5154

52-
func New(driver *driver.BaseDriver) *LimaWslDriver {
55+
func New(inst *store.Instance) *LimaWslDriver {
5356
port, err := freeport.VSock()
5457
if err != nil {
5558
logrus.WithError(err).Error("failed to get free VSock port")
5659
}
57-
driver.VSockPort = port
58-
driver.VirtioPort = ""
60+
5961
return &LimaWslDriver{
60-
BaseDriver: driver,
62+
Instance: inst,
63+
VSockPort: port,
64+
VirtioPort: "",
6165
}
6266
}
6367

@@ -122,10 +126,10 @@ func (l *LimaWslDriver) Start(ctx context.Context) (chan error, error) {
122126
distroName := "lima-" + l.Instance.Name
123127

124128
if status == store.StatusUninitialized {
125-
if err := EnsureFs(ctx, l.BaseDriver); err != nil {
129+
if err := EnsureFs(ctx, l.Instance); err != nil {
126130
return nil, err
127131
}
128-
if err := initVM(ctx, l.BaseDriver.Instance.Dir, distroName); err != nil {
132+
if err := initVM(ctx, l.Instance.Dir, distroName); err != nil {
129133
return nil, err
130134
}
131135
}
@@ -138,8 +142,8 @@ func (l *LimaWslDriver) Start(ctx context.Context) (chan error, error) {
138142

139143
if err := provisionVM(
140144
ctx,
141-
l.BaseDriver.Instance.Dir,
142-
l.BaseDriver.Instance.Name,
145+
l.Instance.Dir,
146+
l.Instance.Name,
143147
distroName,
144148
errCh,
145149
); err != nil {

0 commit comments

Comments
 (0)