Skip to content

Commit 2121c36

Browse files
committed
hostagent/dns: fix panic in TestDNSRecords on Windows
Signed-off-by: Oleksandr Redko <[email protected]>
1 parent ce577b2 commit 2121c36

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

pkg/hostagent/dns/dns_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@ import (
1818
var dnsResult *dns.Msg
1919

2020
func TestDNSRecords(t *testing.T) {
21-
srv, _ := mockdns.NewServerWithLogger(map[string]mockdns.Zone{
21+
if runtime.GOOS == "windows" {
22+
// "On Windows, the resolver always uses C library functions, such as GetAddrInfo and DnsQuery."
23+
t.Skip()
24+
}
25+
26+
srv, err := mockdns.NewServerWithLogger(map[string]mockdns.Zone{
2227
"onerecord.com.": {
2328
TXT: []string{"My txt record"},
2429
},
@@ -32,12 +37,9 @@ func TestDNSRecords(t *testing.T) {
3237
TXT: []string{"record 1", "record 2"},
3338
},
3439
}, log.New(io.Discard, "mockdns server: ", log.LstdFlags), false)
40+
assert.NilError(t, err)
3541
defer srv.Close()
3642

37-
if runtime.GOOS == "windows" {
38-
// "On Windows, the resolver always uses C library functions, such as GetAddrInfo and DnsQuery."
39-
t.Skip()
40-
}
4143
srv.PatchNet(net.DefaultResolver)
4244
defer mockdns.UnpatchNet(net.DefaultResolver)
4345
w := new(TestResponseWriter)

0 commit comments

Comments
 (0)