Skip to content

Commit 3bc6378

Browse files
committed
Don't use aliases in the sudoers file
Their names must be globally unique, so using them prevents the user from registering sudoers files for multiple LIMA_HOME locations. Signed-off-by: Jan Dubois <[email protected]>
1 parent e1d81d2 commit 3bc6378

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

pkg/networks/sudoers.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,11 @@ func Sudoers() (string, error) {
3131
sb.WriteRune('\n')
3232
sb.WriteString(fmt.Sprintf("# Manage %q network daemons\n", name))
3333
for _, daemon := range []string{Switch, VMNet} {
34-
prefix := strings.ToUpper(name + "_" + daemon)
3534
sb.WriteRune('\n')
36-
sb.WriteString(fmt.Sprintf("Cmnd_Alias %s_START = %s\n", prefix, config.StartCmd(name, daemon)))
37-
sb.WriteString(fmt.Sprintf("Cmnd_Alias %s_STOP = %s\n", prefix, config.StopCmd(name, daemon)))
38-
sb.WriteString(fmt.Sprintf("%%%s ALL=(%s:%s) NOPASSWD:NOSETENV: %s_START, %s_STOP\n",
39-
config.Group, config.DaemonUser(daemon), config.DaemonGroup(daemon), prefix, prefix))
35+
sb.WriteString(fmt.Sprintf("%%%s ALL=(%s:%s) NOPASSWD:NOSETENV: \\\n",
36+
config.Group, config.DaemonUser(daemon), config.DaemonGroup(daemon)))
37+
sb.WriteString(fmt.Sprintf(" %s, \\\n", config.StartCmd(name, daemon)))
38+
sb.WriteString(fmt.Sprintf(" %s\n", config.StopCmd(name, daemon)))
4039
}
4140
}
4241
return sb.String(), nil

0 commit comments

Comments
 (0)