Skip to content

Commit 4cd4ce7

Browse files
committed
vz: improve log messages
Signed-off-by: Akihiro Suda <[email protected]>
1 parent 089349c commit 4cd4ce7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

pkg/nativeimgutil/nativeimgutil.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"path/filepath"
1111

1212
"github.com/containerd/continuity/fs"
13+
"github.com/docker/go-units"
1314
"github.com/lima-vm/go-qcow2reader"
1415
"github.com/lima-vm/go-qcow2reader/image/qcow2"
1516
"github.com/lima-vm/go-qcow2reader/image/raw"
@@ -34,6 +35,7 @@ func ConvertToRaw(source, dest string, size *int64, allowSourceWithBackingFile b
3435
if size != nil && *size < srcImg.Size() {
3536
return fmt.Errorf("specified size %d is smaller than the original image size (%d) of %q", *size, srcImg.Size(), source)
3637
}
38+
logrus.Infof("Converting %q (%s) to a raw disk %q", source, srcImg.Type(), dest)
3739
switch t := srcImg.Type(); t {
3840
case raw.Type:
3941
if err = srcF.Close(); err != nil {
@@ -82,6 +84,7 @@ func ConvertToRaw(source, dest string, size *int64, allowSourceWithBackingFile b
8284

8385
// Resize
8486
if size != nil {
87+
logrus.Infof("Expanding to %s", units.BytesSize(float64(*size)))
8588
if err = MakeSparse(destTmpF, *size); err != nil {
8689
return err
8790
}
@@ -105,6 +108,7 @@ func convertRawToRaw(source, dest string, size *int64) error {
105108
}
106109
}
107110
if size != nil {
111+
logrus.Infof("Expanding to %s", units.BytesSize(float64(*size)))
108112
destF, err := os.OpenFile(dest, os.O_RDWR, 0644)
109113
if err != nil {
110114
return err

pkg/vz/disk.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"github.com/lima-vm/lima/pkg/iso9660util"
1313
"github.com/lima-vm/lima/pkg/nativeimgutil"
1414
"github.com/lima-vm/lima/pkg/store/filenames"
15-
"github.com/sirupsen/logrus"
1615
)
1716

1817
func EnsureDisk(driver *driver.BaseDriver) error {
@@ -58,9 +57,8 @@ func EnsureDisk(driver *driver.BaseDriver) error {
5857
}
5958
return diffDiskF.Close()
6059
}
61-
logrus.Infof("Converting %q to a raw disk %q (size=%d)", baseDisk, diffDisk, diskSize)
6260
if err = nativeimgutil.ConvertToRaw(baseDisk, diffDisk, &diskSize, false); err != nil {
63-
return fmt.Errorf("failed to convert %q to a raw disk %q (size=%d): %w", baseDisk, diffDisk, diskSize, err)
61+
return fmt.Errorf("failed to convert %q to a raw disk %q: %w", baseDisk, diffDisk, err)
6462
}
6563
return err
6664
}

0 commit comments

Comments
 (0)