Merge pull request #1268 from balajiv113/disk-perf

AkihiroSuda · web-flow · commit 5a2dea076558 · 2022-12-28T18:19:09.000+09:00
improve vm disk performance with VZDiskImageSynchronizationModeFsync
diff --git a/pkg/vz/vm_darwin.go b/pkg/vz/vm_darwin.go
@@ -278,7 +278,7 @@ func attachDisks(driver *driver.BaseDriver, vmConfig *vz.VirtualMachineConfigura
 	if err = validateDiskFormat(diffDiskPath); err != nil {
 		return err
 	}
-	diffDiskAttachment, err := vz.NewDiskImageStorageDeviceAttachment(diffDiskPath, false)
+	diffDiskAttachment, err := vz.NewDiskImageStorageDeviceAttachmentWithCacheAndSync(diffDiskPath, false, vz.DiskImageCachingModeAutomatic, vz.DiskImageSynchronizationModeFsync)
 	if err != nil {
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ func attachDisks(driver driver.BaseDriver, vmConfig vz.VirtualMachineConfigura`
`278`	`278`	`if err = validateDiskFormat(diffDiskPath); err != nil {`
`279`	`279`	`return err`
`280`	`280`	`}`
`281`		`- diffDiskAttachment, err := vz.NewDiskImageStorageDeviceAttachment(diffDiskPath, false)`
	`281`	`+ diffDiskAttachment, err := vz.NewDiskImageStorageDeviceAttachmentWithCacheAndSync(diffDiskPath, false, vz.DiskImageCachingModeAutomatic, vz.DiskImageSynchronizationModeFsync)`
`282`	`282`	`if err != nil {`
`283`	`283`	`return err`
`284`	`284`	`}`