Merge pull request #2247 from rancher-sandbox/inotify-witherror

AkihiroSuda · web-flow · commit 643ddd8aa573 · 2024-03-14T07:01:39.000+09:00
Remove redundant err from logrus that already uses WithError(err)
diff --git a/pkg/hostagent/hostagent.go b/pkg/hostagent/hostagent.go
@@ -598,7 +598,7 @@ func (a *HostAgent) watchGuestAgentEvents(ctx context.Context) {
 			}
 			err := a.startInotify(ctx)
 			if err != nil {
-				logrus.WithError(err).Warn("failed to start inotify", err)
+				logrus.WithError(err).Warn("failed to start inotify")
 			}
 		}
 	}()

Original file line number	Diff line number	Diff line change
`@@ -598,7 +598,7 @@ func (a *HostAgent) watchGuestAgentEvents(ctx context.Context) {`
`598`	`598`	`}`
`599`	`599`	`err := a.startInotify(ctx)`
`600`	`600`	`if err != nil {`
`601`		`- logrus.WithError(err).Warn("failed to start inotify", err)`
	`601`	`+ logrus.WithError(err).Warn("failed to start inotify")`
`602`	`602`	`}`
`603`	`603`	`}`
`604`	`604`	`}()`