Skip to content

Commit 6783398

Browse files
committed
Add warnings for experimental features
Signed-off-by: Akihiro Suda <[email protected]>
1 parent e939454 commit 6783398

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

cmd/limactl/start.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,7 @@ func modifyInPlace(st *creatorState) error {
280280
if st.yq == "" {
281281
return nil
282282
}
283+
logrus.Warn("`--set` is experimental")
283284
out, err := yqutil.EvaluateExpression(st.yq, st.yBytes)
284285
if err != nil {
285286
return err

pkg/limayaml/validate.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,9 @@ func Validate(y LimaYAML, warn bool) error {
270270
if err := validateNetwork(y, warn); err != nil {
271271
return err
272272
}
273+
if warn {
274+
warnExperimental(y)
275+
}
273276
return nil
274277
}
275278

@@ -414,3 +417,18 @@ func validatePort(field string, port int) error {
414417
}
415418
return nil
416419
}
420+
421+
func warnExperimental(y LimaYAML) {
422+
if *y.MountType == NINEP {
423+
logrus.Warn("`mountType: 9p` is experimental")
424+
}
425+
if *y.VMType == VZ {
426+
logrus.Warn("`vmType: vz` is experimental")
427+
}
428+
if *y.Arch == RISCV64 {
429+
logrus.Warn("`arch: riscv64` is experimental")
430+
}
431+
if y.Video.Display != nil && strings.Contains(*y.Video.Display, "vnc") {
432+
logrus.Warn("`video.display: vnc` is experimental")
433+
}
434+
}

0 commit comments

Comments
 (0)