prevent user from editing vm-type

Signed-off-by: Ansuman Sahoo <[email protected]>

Author: unsuman

cmd/limactl/edit.go

@@ -114,6 +114,10 @@ func editAction(cmd *cobra.Command, args []string) error {
 		logrus.Info("Aborting, no changes made to the instance")
 		return nil
 	}
+	if err := limayaml.ValidateAgainstLatestConfig(yBytes, yContent); err != nil {
+		return saveRejectedYAML(yBytes, err)
+	}
+
 	y, err := limayaml.LoadWithWarnings(yBytes, filePath)
 	if err != nil {
 		return err
@@ -122,10 +126,6 @@ func editAction(cmd *cobra.Command, args []string) error {
 		return saveRejectedYAML(yBytes, err)
 	}
 
-	if err := limayaml.ValidateAgainstLatestConfig(yBytes, yContent); err != nil {
-		return saveRejectedYAML(yBytes, err)
-	}
-
 	if err := os.WriteFile(filePath, yBytes, 0o644); err != nil {
 		return err
 	}

pkg/limayaml/load.go

@@ -73,15 +73,15 @@ func load(b []byte, filePath string, warn bool) (*limatype.LimaYAML, error) {
 
 	FillDefault(&y, &d, &o, filePath, warn)
 
-	if err := ResolveVMType(&y, filePath); err != nil {
+	if err := ValidateVMType(&y, filePath); err != nil {
 		logrus.WithError(err).Warnf("Failed to accept config for %q", filePath)
 		return nil, fmt.Errorf("failed to accept config for %q: %w", filePath, err)
 	}
 
 	return &y, nil
 }
 
-func ResolveVMType(y *limatype.LimaYAML, filePath string) error {
+func ValidateVMType(y *limatype.LimaYAML, filePath string) error {
 	if y.VMType != nil && *y.VMType != "" {
 		vmType := *y.VMType
 		_, intDriver, exists := registry.Get(vmType)
@@ -112,7 +112,7 @@ func ResolveVMType(y *limatype.LimaYAML, filePath string) error {
 		if registry.CheckInternalOrExternal(vmType) == registry.Internal {
 			_, intDriver, _ := registry.Get(vmType)
 			if err := intDriver.AcceptConfig(y, filePath); err == nil {
-				logrus.Infof("ResolveVMType: resolved VMType %q", vmType)
+				logrus.Debugf("ResolveVMType: resolved VMType %q", vmType)
 				y.VMType = ptr.Of(vmType)
 				return nil
 			}

pkg/limayaml/validate.go

@@ -605,6 +605,10 @@ func ValidateAgainstLatestConfig(yNew, yLatest []byte) error {
 		return err
 	}
 
+	if *n.VMType != *l.VMType {
+		return fmt.Errorf("cannot change VMType from %v to %v, please create a new instance with the desired VMType", *l.VMType, *n.VMType)
+	}
+
 	// Handle editing the template without a disk value
 	if n.Disk == nil || l.Disk == nil {
 		return nil