Merge pull request #3835 from jandubois/nfs-check

For IsNFS check all parent directories up to the root until one exist

Author: jandubois

cmd/limactl/main.go

@@ -134,12 +134,6 @@ func newApp() *cobra.Command {
 		if err != nil {
 			return err
 		}
-		// Make sure that directory is on a local filesystem, not on NFS
-		// if the directory does not yet exist, check the home directory
-		_, err = os.Stat(dir)
-		if errors.Is(err, os.ErrNotExist) {
-			dir = filepath.Dir(dir)
-		}
 		nfs, err := fsutil.IsNFS(dir)
 		if err != nil {
 			return err

pkg/fsutil/fsutil_linux.go

@@ -4,10 +4,28 @@
 package fsutil
 
 import (
+	"errors"
+	"os"
+	"path/filepath"
+
 	"golang.org/x/sys/unix"
 )
 
+// IsNFS checks if the path is on NFS. If the path does not exist yet, it will walk
+// up parent directories until one exists, or it hits '/' or '.'.
+// Any other stat errors will cause IsNFS to fail.
 func IsNFS(path string) (bool, error) {
+	for len(path) > 1 {
+		_, err := os.Stat(path)
+		if err == nil {
+			break
+		}
+		if !errors.Is(err, os.ErrNotExist) {
+			return false, err
+		}
+		path = filepath.Dir(path)
+	}
+
 	var sf unix.Statfs_t
 	if err := unix.Statfs(path, &sf); err != nil {
 		return false, err