fix: Prevent panic when validating minimumLimaVersion

Signed-off-by: Oleksandr Redko <[email protected]>

Author: alexandear

pkg/limayaml/validate.go

@@ -39,13 +39,13 @@ func Validate(y *LimaYAML, warn bool) error {
 	if y.MinimumLimaVersion != nil {
 		if _, err := versionutil.Parse(*y.MinimumLimaVersion); err != nil {
 			errs = errors.Join(errs, fmt.Errorf("field `minimumLimaVersion` must be a semvar value, got %q: %w", *y.MinimumLimaVersion, err))
-		}
-		limaVersion, err := versionutil.Parse(version.Version)
-		if err != nil {
-			errs = errors.Join(errs, fmt.Errorf("can't parse builtin Lima version %q: %w", version.Version, err))
-		}
-		if versionutil.GreaterThan(*y.MinimumLimaVersion, limaVersion.String()) {
-			errs = errors.Join(errs, fmt.Errorf("template requires Lima version %q; this is only %q", *y.MinimumLimaVersion, limaVersion.String()))
+		} else {
+			limaVersion, err := versionutil.Parse(version.Version)
+			if err != nil {
+				errs = errors.Join(errs, fmt.Errorf("can't parse builtin Lima version %q: %w", version.Version, err))
+			} else if versionutil.GreaterThan(*y.MinimumLimaVersion, limaVersion.String()) {
+				errs = errors.Join(errs, fmt.Errorf("template requires Lima version %q; this is only %q", *y.MinimumLimaVersion, limaVersion.String()))
+			}
 		}
 	}
 	if y.VMOpts.QEMU.MinimumVersion != nil {

pkg/limayaml/validate_test.go

@@ -8,6 +8,8 @@ import (
 	"testing"
 
 	"gotest.tools/v3/assert"
+
+	"github.com/lima-vm/lima/pkg/version"
 )
 
 func TestValidateEmpty(t *testing.T) {
@@ -17,6 +19,60 @@ func TestValidateEmpty(t *testing.T) {
 	assert.Error(t, err, "field `images` must be set")
 }
 
+func TestValidateMinimumLimaVersion(t *testing.T) {
+	images := `images: [{"location": "/"}]`
+
+	tests := []struct {
+		name               string
+		currentVersion     string
+		minimumLimaVersion string
+		wantErr            string
+	}{
+		{
+			name:               "minimumLimaVersion less than current version",
+			currentVersion:     "1.1.1-114-g5bf5e513",
+			minimumLimaVersion: "1.1.0",
+			wantErr:            "",
+		},
+		{
+			name:               "minimumLimaVersion greater than current version",
+			currentVersion:     "1.1.1-114-g5bf5e513",
+			minimumLimaVersion: "1.1.2",
+			wantErr:            `template requires Lima version "1.1.2"; this is only "1.1.1"`,
+		},
+		{
+			name:               "invalid current version",
+			currentVersion:     "<unknown>",
+			minimumLimaVersion: "0.8.0",
+			wantErr:            `can't parse builtin Lima version "<unknown>": <unknown> is not in dotted-tri format`,
+		},
+		{
+			name:               "invalid minimumLimaVersion",
+			currentVersion:     "1.1.1-114-g5bf5e513",
+			minimumLimaVersion: "invalid",
+			wantErr:            "field `minimumLimaVersion` must be a semvar value, got \"invalid\": invalid is not in dotted-tri format",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			oldVersion := version.Version
+			version.Version = tt.currentVersion
+			t.Cleanup(func() { version.Version = oldVersion })
+
+			y, err := Load([]byte("minimumLimaVersion: "+tt.minimumLimaVersion+"\n"+images), "lima.yaml")
+			assert.NilError(t, err)
+
+			err = Validate(y, false)
+			if tt.wantErr == "" {
+				assert.NilError(t, err)
+			} else {
+				assert.Error(t, err, tt.wantErr)
+			}
+		})
+	}
+}
+
 func TestValidateProbes(t *testing.T) {
 	images := `images: [{"location": "/"}]`
 	validProbe := `probes: [{"script": "#!foo"}]`