Skip to content

Commit a1f79d5

Browse files
committed
refactor(BaseDriver): remove driver.BaseDriver from driver(vz) level
Signed-off-by: Ansuman Sahoo <[email protected]>
1 parent c01a36d commit a1f79d5

File tree

4 files changed

+93
-134
lines changed

4 files changed

+93
-134
lines changed

pkg/vz/disk.go

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,36 +11,35 @@ import (
1111
"path/filepath"
1212

1313
"github.com/docker/go-units"
14-
15-
"github.com/lima-vm/lima/pkg/driver"
1614
"github.com/lima-vm/lima/pkg/fileutils"
1715
"github.com/lima-vm/lima/pkg/iso9660util"
1816
"github.com/lima-vm/lima/pkg/nativeimgutil"
17+
"github.com/lima-vm/lima/pkg/store"
1918
"github.com/lima-vm/lima/pkg/store/filenames"
2019
)
2120

22-
func EnsureDisk(ctx context.Context, driver *driver.BaseDriver) error {
23-
diffDisk := filepath.Join(driver.Instance.Dir, filenames.DiffDisk)
21+
func EnsureDisk(ctx context.Context, inst *store.Instance) error {
22+
diffDisk := filepath.Join(inst.Dir, filenames.DiffDisk)
2423
if _, err := os.Stat(diffDisk); err == nil || !errors.Is(err, os.ErrNotExist) {
2524
// disk is already ensured
2625
return err
2726
}
2827

29-
baseDisk := filepath.Join(driver.Instance.Dir, filenames.BaseDisk)
30-
kernel := filepath.Join(driver.Instance.Dir, filenames.Kernel)
31-
kernelCmdline := filepath.Join(driver.Instance.Dir, filenames.KernelCmdline)
32-
initrd := filepath.Join(driver.Instance.Dir, filenames.Initrd)
28+
baseDisk := filepath.Join(inst.Dir, filenames.BaseDisk)
29+
kernel := filepath.Join(inst.Dir, filenames.Kernel)
30+
kernelCmdline := filepath.Join(inst.Dir, filenames.KernelCmdline)
31+
initrd := filepath.Join(inst.Dir, filenames.Initrd)
3332
if _, err := os.Stat(baseDisk); errors.Is(err, os.ErrNotExist) {
3433
var ensuredBaseDisk bool
35-
errs := make([]error, len(driver.Instance.Config.Images))
36-
for i, f := range driver.Instance.Config.Images {
37-
if _, err := fileutils.DownloadFile(ctx, baseDisk, f.File, true, "the image", *driver.Instance.Config.Arch); err != nil {
34+
errs := make([]error, len(inst.Config.Images))
35+
for i, f := range inst.Config.Images {
36+
if _, err := fileutils.DownloadFile(ctx, baseDisk, f.File, true, "the image", *inst.Config.Arch); err != nil {
3837
errs[i] = err
3938
continue
4039
}
4140
if f.Kernel != nil {
4241
// ensure decompress kernel because vz expects it to be decompressed
43-
if _, err := fileutils.DownloadFile(ctx, kernel, f.Kernel.File, true, "the kernel", *driver.Instance.Config.Arch); err != nil {
42+
if _, err := fileutils.DownloadFile(ctx, kernel, f.Kernel.File, true, "the kernel", *inst.Config.Arch); err != nil {
4443
errs[i] = err
4544
continue
4645
}
@@ -52,7 +51,7 @@ func EnsureDisk(ctx context.Context, driver *driver.BaseDriver) error {
5251
}
5352
}
5453
if f.Initrd != nil {
55-
if _, err := fileutils.DownloadFile(ctx, initrd, *f.Initrd, false, "the initrd", *driver.Instance.Config.Arch); err != nil {
54+
if _, err := fileutils.DownloadFile(ctx, initrd, *f.Initrd, false, "the initrd", *inst.Config.Arch); err != nil {
5655
errs[i] = err
5756
continue
5857
}
@@ -64,7 +63,7 @@ func EnsureDisk(ctx context.Context, driver *driver.BaseDriver) error {
6463
return fileutils.Errors(errs)
6564
}
6665
}
67-
diskSize, _ := units.RAMInBytes(*driver.Instance.Config.Disk)
66+
diskSize, _ := units.RAMInBytes(*inst.Config.Disk)
6867
if diskSize == 0 {
6968
return nil
7069
}

0 commit comments

Comments
 (0)